Skip to content

Conversation

@maximthomas
Copy link
Contributor

No description provided.

@maximthomas maximthomas requested review from aldaris and vharseko July 7, 2025 07:09
<!-- Supress checkstyle errors on legacy com.iplanet and com.sun.identity packages -->
<checkstyleUnitTestSuppressionsLocation>checkstyle/suppressions.xml</checkstyleUnitTestSuppressionsLocation>
<opendj.version>4.9.4</opendj.version>
<opendj.version>4.9.5-SNAPSHOT</opendj.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the weird things I haven't understood yet. If the products bring in consistently the same commons BOM, you get better separation of responsibilities. (Right now IG ships with DJ, because openig-saml brings in openam-shared that depends on opendj-core/grizzly for some reason?) Also it would mean that patching commons wouldn't need additional changes in opendj as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good question.
Ideally the commons project should declare all shared project dependencies. In this particular case, there is a jQuery version update in the commons project. OpenAM imports the commons BOM via the OpenDJ project. Thus, we need to update the OpenDJ version in OpenAM to import the updated jQuery dependency from the commons project.

@aldaris
Copy link
Contributor

aldaris commented Jul 9, 2025

Don't know much about the JS side of things, assuming it was tested.

@vharseko vharseko merged commit 4c98ce2 into OpenIdentityPlatform:master Jul 11, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants