CVE-2019-11358 CVE-2020-11023 Update jQuery to 3.7.1 #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vharseko
changed the title
vharseko
approved these changes
Jul 4, 2025
aldaris
approved these changes
Jul 4, 2025
Contributor
aldaris
left a comment
aldaris
left a comment
There was a problem hiding this comment.
Honestly I'm not sure about whether there are any API breakages between these two versions, and I'm not the best expert on JS development. I'm assuming you've tested these changes, and the UIs were still working.
| "org/forgerock/commons/ui/common/main/EventManager", | ||
| "org/forgerock/commons/ui/common/main/SpinnerManager", | ||
| "org/forgerock/commons/ui/common/main/ErrorsHandler" | ||
| ], function($, _, Constants, EventManager, spinner, errorsHandler) { |
Contributor
There was a problem hiding this comment.
// double space in front of errorsHandler
Contributor
Author
|
FYU: jQuery 3 introduced breaking changes in Deferreds, which affects UI functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.