adding JAVA_HOME env variable for product info based on java.home#501
Merged
venmanyarun merged 1 commit intoOpenLiberty:mainfrom Feb 26, 2026
Merged
Conversation
Signed-off-by: Arun Venmany <arun.kumar.v.n@ibm.com>
cherylking
requested changes
Feb 25, 2026
src/main/java/io/openliberty/tools/common/plugins/util/InstallFeatureUtil.java
Show resolved
Hide resolved
cherylking
approved these changes
Feb 26, 2026
Member
cherylking
left a comment
There was a problem hiding this comment.
I'm approving this PR, but I want the other issue resolved before we do another release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing OpenLiberty/ci.gradle#1060
Similar code is already present in ci.ant for server task and we are adding for ProductInfo
https://github.com/OpenLiberty/ci.ant/blob/26245d3e002293b4babc1efde6f3ab7089a51521/src/main/java/io/openliberty/tools/ant/ServerTask.java#L113