Fix check for ear dependency for dependencies of type ejb

[arend-von-reinersdorff]

Fixes #1941

This extended check is already used in DeployMojoSupport.addSkinnyArtifactLib()

I tested the fix locally. There is a test project dealing with skinny wars already: https://github.com/OpenLiberty/ci.maven/tree/main/liberty-maven-plugin/src/it/dev-it/resources/multi-module-projects/multipleLibertyModules Maybe it could be extended with an EJB dependency? But I don't know how to run these tests.

[venmanyarun]

Hi @arend-von-reinersdorff
Please refer https://github.com/OpenLiberty/ci.maven/blob/main/README.md#build to run tests in local
Yes you need to update tests
https://github.com/OpenLiberty/ci.maven/tree/main/liberty-maven-plugin/src/it/dev-it/resources/multi-module-projects/multipleLibertyModules -> add an ejb module here and update dependencies in ear-skinny-modules module , war module etc
and you need to update ear-project-it and add ejb module for skinnywar-ear and update the necessary tests too

Also take latest update from main to resolve PR check failure issue

[venmanyarun]

I see that you have updated the test project , but no changes in

ci.maven/liberty-maven-plugin/src/it/dev-it/src/test/java/net/wasdev/wlp/test/dev/it/MultipleLibertyModulesSkinnyModulesTest.java

Line 41 in 5378fc2

public class MultipleLibertyModulesSkinnyModulesTest extends BaseMultiModuleTest {

and
https://github.com/OpenLiberty/ci.maven/blob/5378fc245f517e284898b7b1815da3ba841bf84f/liberty-maven-plugin/src/it/dev-it/resources/multi-module-projects/multipleLibertyModules/ear-skinny-modules/src/test/java/it/io/openliberty/guides/multimodules/ConverterAppIT.java

You need to update ConverterAppIT to see whether the ear.xml is containing the ejb in the correct position

[arend-von-reinersdorff]

I see that you have updated the test project , but no changes in

ci.maven/liberty-maven-plugin/src/it/dev-it/src/test/java/net/wasdev/wlp/test/dev/it/MultipleLibertyModulesSkinnyModulesTest.java

Line 41 in 5378fc2

public class MultipleLibertyModulesSkinnyModulesTest extends BaseMultiModuleTest {

and https://github.com/OpenLiberty/ci.maven/blob/5378fc245f517e284898b7b1815da3ba841bf84f/liberty-maven-plugin/src/it/dev-it/resources/multi-module-projects/multipleLibertyModules/ear-skinny-modules/src/test/java/it/io/openliberty/guides/multimodules/ConverterAppIT.java

You need to update ConverterAppIT to see whether the ear.xml is containing the ejb in the correct position

Hi @venmanyarun, thanks for looking it over. I adapted ConverterAppIT now and it behaves as expected: Succeeds with the main code change and fails without it.

There are other failing tests in the dev-it directory, but they mostly also fail for me when running them on main.

[venmanyarun]

@arend-von-reinersdorff
Thank you very much for the contribution!!

Looks good to me.. @cherylking please check

[venmanyarun]

Hi @arend-von-reinersdorff
can you confirm whether you have followed the process for contributor agreement
Please read through the document and signoff on the CLA

[arend-von-reinersdorff]

Hi @arend-von-reinersdorff can you confirm whether you have followed the process for contributor agreement Please read through the document and signoff on the CLA

Hi @venmanyarun, submitted the CLA via email now

[cherylking]

Looks good to me. Thanks for the contribution!

[cherylking]

Confirmed we received the CLA and it has been approved. Thank you!