Toolchain support for DevMode#1949
Merged
venmanyarun merged 6 commits intoOpenLiberty:mainfrom Jan 7, 2026
Merged
Conversation
…Toolchain for testing
cherylking
requested changes
Dec 18, 2025
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java
Outdated
Show resolved
Hide resolved
venmanyarun
reviewed
Dec 24, 2025
...ty-maven-plugin/src/it/dev-it/src/test/java/net/wasdev/wlp/test/dev/it/DevToolchainTest.java
Outdated
Show resolved
Hide resolved
venmanyarun
reviewed
Dec 24, 2025
...ty-maven-plugin/src/it/dev-it/src/test/java/net/wasdev/wlp/test/dev/it/DevToolchainTest.java
Outdated
Show resolved
Hide resolved
venmanyarun
reviewed
Dec 24, 2025
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/utils/ExecuteMojoUtil.java
Show resolved
Hide resolved
venmanyarun
reviewed
Dec 24, 2025
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/utils/ExecuteMojoUtil.java
Show resolved
Hide resolved
venmanyarun
requested changes
Dec 24, 2025
Contributor
venmanyarun
left a comment
venmanyarun
left a comment
There was a problem hiding this comment.
I think DevToolchainTest should be running only in linux in pipelines, as we have disabled dev mode tests in windows..
I can see its running fine now.. try after adding more tests and exclude it if necessary
Contributor
Author
DevToolchainTest comes under the dev-it, and it is already excluded in pom |
venmanyarun
approved these changes
Jan 6, 2026
cherylking
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added toolchain support for devmode, compiler plugin. Also enabled jdkToolchain for testing.
Compiler plugin will now use toolchain level jdk version. If the user have a different jdk toolchain configuration for the compiler plugin, we will show the warning as well (Priority goes to our plugins toolchain).