Feature/validate @resource type compatibility#1519
Open
Rejoice472 wants to merge 10 commits intoOpenLiberty:lsp4jakarta-0.2.6-integration-branchfrom
Open
Feature/validate @resource type compatibility#1519Rejoice472 wants to merge 10 commits intoOpenLiberty:lsp4jakarta-0.2.6-integration-branchfrom
Rejoice472 wants to merge 10 commits intoOpenLiberty:lsp4jakarta-0.2.6-integration-branchfrom
Conversation
…date-@Resource-type-compatibility
Contributor
|
The issue ticks quick fix too, are we raising a separate PR for quick fix? |
Contributor
Author
Yes, we will raise a separate PR for the quick fixes, since two have been identified and they require more work. |
archana-1924
approved these changes
Feb 4, 2026
Contributor
|
Do we have validation for class similar to method and field? I can see similar changes in jakarta PR. |
Contributor
Author
Yes. we have |
archana-1924
suggested changes
Feb 10, 2026
| PsiParameter param = element.getParameterList().getParameter(0); | ||
| checkTypeCompatibility(unit, diagnostics, annotation, param.getType(), "parameter"); | ||
| } | ||
| default -> System.out.println("Unexpected value"); |
Contributor
There was a problem hiding this comment.
Please change this to logger
Contributor
Author
Yes . that is already existing one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a synch up pr raised to address the lsp4jakarta issue eclipse-lsp4jakarta/lsp4jakarta#662
corresponding lsp4jakarta pr link -> eclipse-lsp4jakarta/lsp4jakarta#799
Screen.Recording.2026-02-04.at.9.59.43.AM.mov