Lsp4jakarta issue 624#1520
Open
Joseph-Bineesh wants to merge 5 commits intoOpenLiberty:lsp4jakarta-0.2.6-integration-branchfrom
Open
Lsp4jakarta issue 624#1520Joseph-Bineesh wants to merge 5 commits intoOpenLiberty:lsp4jakarta-0.2.6-integration-branchfrom
Joseph-Bineesh wants to merge 5 commits intoOpenLiberty:lsp4jakarta-0.2.6-integration-branchfrom
Conversation
Rejoice472
suggested changes
Feb 13, 2026
| private boolean validateSetterMethod(PsiMethod method) { | ||
| return method.getName().startsWith("set") && PsiTypes.voidType().equals(method.getReturnType()) | ||
| && method.getParameterList().getParametersCount() == 1 | ||
| && method.getModifierList().hasModifierProperty(PsiModifier.PUBLIC); |
Contributor
There was a problem hiding this comment.
Do we need to check the property name inside the method name rule?
Contributor
Author
There was a problem hiding this comment.
Not required as of now based on spec. We can add this once we introduce the utility method.
| * @return true if the java element name matches the given fully qualified java | ||
| * element name and false otherwise. | ||
| */ | ||
| public static boolean isMatchedJavaElement(PsiClass type, String javaElementName, String javaElementFQName) { |
Contributor
There was a problem hiding this comment.
This method is actually a duplicate.
Could you please use AbstractDiagnosticsCollector.isMatchedJavaElement if possible
Contributor
Author
There was a problem hiding this comment.
The method is referred from Util class. So avoid using AbstractDiagnosticsCollector.
Rejoice472
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lsp4akarta Issue: eclipse-lsp4jakarta/lsp4jakarta#624
lsp4akarta PR: eclipse-lsp4jakarta/lsp4jakarta#804