LCLS Automated test case implemented for server.xml #430
LCLS Automated test case implemented for server.xml #430SuparnaSuresh wants to merge 45 commits intoOpenLiberty:mainfrom
Conversation
src/test/GradleSingleModLCLSTest.ts
Outdated
| }).timeout(35000); | ||
|
|
||
| it('Should show type ahead support in server.xml Liberty Server Configuration Stanza', async () => { | ||
| const section = await new SideBarView().getContent().getSection(constants.GRADLE_PROJECT); |
There was a problem hiding this comment.
Move the duplicate code to testutils.
There was a problem hiding this comment.
Addressed. Thanks
….com/SuparnaSuresh/liberty-tools-vscode into issue392-TypeaheadServerConfigStanza
| }); | ||
|
|
||
| it('Should copy content of server.xml', async () => { | ||
| await utils.openConfigFile(constants.CONFIG_TWO, constants.SERVER_XML) |
There was a problem hiding this comment.
This method is for opening server.xml right? then the method name should be updated.
There was a problem hiding this comment.
Addressed. Thanks
|
|
||
| actualServerXMLContent = await editor.getText(); | ||
| assert(actualServerXMLContent.length !== 0, 'Content of server.xml is not in copied.'); | ||
| console.log('Sever.xml content is:', actualServerXMLContent); |
There was a problem hiding this comment.
remove unnecessary log statements
There was a problem hiding this comment.
Addressed. Thanks
| editor.clearText(); | ||
| editor.setText(actualServerXMLContent); | ||
| console.log("server.xml content is restored"); | ||
| await utils.closeEditor(constants.SERVER_XML); |
There was a problem hiding this comment.
This method is for closing the opened file, so please update the method name accordingly.
There was a problem hiding this comment.
Addressed. Thanks.
|
|
||
| }).timeout(45000); | ||
|
|
||
| it('Should show type ahead support in server.xml Liberty Server Feature', async () => { |
There was a problem hiding this comment.
Instead of 'type ahead', use the word 'completion'.
There was a problem hiding this comment.
Addressed. Thanks.
src/test/utils/testUtils.ts
Outdated
| * @param configFileName | ||
| * Open specific config file from parent directory | ||
| */ | ||
| export async function openConfigFile(parentDir: string, configFileName: string) { |
There was a problem hiding this comment.
this method opens any file not the config file, so change the method name accordingly.
There was a problem hiding this comment.
Addressed. Thanks.
aparnamichael
left a comment
aparnamichael
left a comment
There was a problem hiding this comment.
Please address the review comments.
src/test/definitions/constants.ts
Outdated
| @@ -1,3 +1,4 @@ | |||
|
|
|||
| /** | |||
| * Copyright (c) 2020, 2022 IBM Corporation. | |||
There was a problem hiding this comment.
Update the year in copyright header.
There was a problem hiding this comment.
Addressed. Thanks.
|
Review comments addressed. Thanks |
SuparnaSuresh
changed the title
2 participants
Fixes #392, Fixes #370, Fixes #434, Fixes #378, Fixes #381, Fixes #391
LCLS Test case implemented for server.xml.