Issue 124 - Automated test implementation for bootstrap.properties -LCLS#431
Open
SuparnaSuresh wants to merge 45 commits intoOpenLiberty:mainfrom
Open
Issue 124 - Automated test implementation for bootstrap.properties -LCLS#431SuparnaSuresh wants to merge 45 commits intoOpenLiberty:mainfrom
SuparnaSuresh wants to merge 45 commits intoOpenLiberty:mainfrom
Conversation
|
|
||
| }).timeout(65000); | ||
|
|
||
| it('Should show type ahead support in bootstrap.properties for a Liberty Server Configuration booststrap.properties entry', async () => { |
Contributor
There was a problem hiding this comment.
use the word 'completion' instead of 'type ahead'
Contributor
Author
There was a problem hiding this comment.
Addressed. Thanks
src/test/utils/testUtils.ts
Outdated
| * @param configFileName | ||
| * Open specific config file from parent directory | ||
| */ | ||
| export async function openConfigFile(parentDir: string, configFileName: string) { |
Contributor
There was a problem hiding this comment.
Update with more meanigful name for the method.
Contributor
Author
There was a problem hiding this comment.
Addressed. Thanks
aparnamichael
requested changes
Feb 3, 2025
Contributor
aparnamichael
left a comment
aparnamichael
left a comment
There was a problem hiding this comment.
Please address the review comments.
src/test/definitions/constants.ts
Outdated
| @@ -1,3 +1,4 @@ | |||
|
|
|||
| /** | |||
| * Copyright (c) 2020, 2022 IBM Corporation. | |||
Contributor
There was a problem hiding this comment.
Update the year in copyright header.
Contributor
Author
There was a problem hiding this comment.
Addressed. Thanks
Contributor
Author
|
Review comments addressed. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #438 includes,
Fixes #425, Fixes #426 , Fixes #423
Test case implemented for bootstrap.properties -