fix(giop): use Latin-1 charset to encode op name#767
Merged
ngmr merged 1 commit intoOpenLiberty:mainfrom Feb 25, 2026
Merged
Conversation
- Replace String.getBytes() with String.getBytes(ISO_8859_1) in GIOPOutgoingMessage - Add static import for StandardCharsets.ISO_8859_1 - Remove unused ISO_LATIN_1 import from GIOPClient - Reorder imports in GIOPClient for consistency - Ensure operation names are consistently encoded using ISO-8859-1 charset in GIOP 1.0, 1.1, and 1.2 messages This change makes the charset encoding explicit rather than relying on the platform default, improving portability and preventing potential encoding issues across different systems.
ngmr
approved these changes
Feb 25, 2026
joe-chacko
deleted the
fix/specify-charset-when-getting-bytes-for-op-name
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the charset encoding explicit rather than relying on the platform default, improving portability and preventing potential encoding issues across different systems.