Add some E1.37-5 PIDs and accompanying RDM tests #1996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripton
approved these changes
Mar 9, 2025
peternewman
commented
Mar 9, 2025
| /** | ||
| * @brief Convert a TagSet to a human readable string. | ||
| * @returns a comma separated string with the Tags from the set. | ||
| * @note Commas can also exist within the tags themselves... |
Member
Author
There was a problem hiding this comment.
Thoughts on how best to handle this? I don't think any of our other ToStrings return a multi-line string which would be the other obvious way to list them. Also probably not too handy in general usage, so I guess just risking the confusing comma is probably worth it.
Member
Author
There was a problem hiding this comment.
I'd missed that you'd approved it as well as the comments. I'll merge this ready for the next one anyway @kripton . But would be curious on a second point of view on this point...
peternewman
merged commit e8c755c
into
OpenLightingProject:master
16 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1993 , Closes #1969