Skip to content

Fix Sid dependencies and autopkgtest #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peternewman merged 2 commits into from
Mar 30, 2026
Merged

Fix Sid dependencies and autopkgtest #2033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a324646
Add equivs to build tools installation
peternewman Mar 9, 2026
15948e7
Update dependencies in debian tests control file to fix RDM tests com…
peternewman Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/debian.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
with:
persist-credentials: false
- name: Install build tools
run: apt-get -y install devscripts adduser fakeroot sudo
run: apt-get -y install devscripts adduser fakeroot sudo equivs
- name: Install build dependencies
run: mk-build-deps -t "apt-get -y -o Debug::pkgProblemResolver=yes --no-install-recommends" -i -r
- name: Set up build user
Expand Down
2 changes: 1 addition & 1 deletion debian/tests/control
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Test-Command: ola_rdm_get --list-pids
Depends: ola

Test-Command: set -e ; for py in $(py3versions -s 2>/dev/null) ; do echo "Testing with $py:" ; $py $(which rdm_responder_test.py) --help ; done
Depends: ola-rdm-tests
Depends: python3-all, ola-rdm-tests
Copy link
Copy Markdown
Member

@DaAwesomeP DaAwesomeP Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be python3-all or can it be a smaller subset?

I'm wondering if this is really required since the sid build has been failing due to other factors. Where did this pop up?

Copy link
Copy Markdown
Member Author

@peternewman peternewman Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied what the ola-python test has been doing for 3+ years, but @yoe would definitely be the expert:
https://github.com/peternewman/ola/blob/15948e72bc3eda5ba156bffb4a1f1da11e02d344/debian/tests/control#L10-L11

I think the idea is python3-all pulls in all the versions of python on that OS ( https://packages.debian.org/sid/python3-all ) and the you can use py3versions to confirm they're all compatible, which they should be currently...

I'm wondering if this is really required since the sid build has been failing due to other factors. Where did this pop up?

Yeah I finally had a look, and it was just due to the missing equivs package (I assume some code was split out).

All the sid build and test worked after this (on 0.10 branch):
https://github.com/OpenLightingProject/ola/actions/runs/22869778604/job/66347046491#step:8:725

Copy link
Copy Markdown
Contributor

@yoe yoe Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wellll, calling me the expert might be pushing it a bit, in this case.

I just took the shortcut of "this will work and I don't have time to do dig into too many details here do shut up and get python3-all kthxbye".

It's very much possible that this will work with a smaller subset too, but I wouldn't know what exactly is required...

Copy link
Copy Markdown
Member

@DaAwesomeP DaAwesomeP Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah OK makes sense. Let's keep the python3-all for now.

Copy link
Copy Markdown
Contributor

@aroffringa aroffringa Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion, but I suspect depending on python3 instead of python3-all might be more appropriate; we just need one version of python here don't we?

Copy link
Copy Markdown
Contributor

@aroffringa aroffringa Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry -- Never mind, I indeed see py3versions is used to iterate over the versions, so then it might be useful to install just all versions available.

Copy link
Copy Markdown
Member Author

@peternewman peternewman Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry -- Never mind, I indeed see py3versions is used to iterate over the versions, so then it might be useful to install just all versions available.

Yes exactly, we want to test widely and see what breaks at this stage!

Copy link
Copy Markdown
Member Author

@peternewman peternewman Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very much possible that this will work with a smaller subset too, but I wouldn't know what exactly is required...

Well it would, but presumably if those versions are all available on sid, we should ideally confirm OLA works with all those versions of Python on sid?


Test-Command: set -e ; for py in $(py3versions -s 2>/dev/null) ; do cd "$ADTTMP" ; echo "Testing with $py:" ; $py -c "from ola.ClientWrapper import ClientWrapper; print(ClientWrapper)" ; done
Depends: python3-all, ola, ola-python
Expand Down
Loading