Add fixture varytec/hero-wash-640fx
#3656
Conversation
luc122c
added
new-fixture
|
@luc122c I fixed the issues that occurred with the new JSON schema. Are there any other things you'd like me to change in order to integrate this fixture? |
FloEdelmann
removed
the
component-fixture
Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
Maybe we should add a comment regarding values 11:80 there as the fixture is doing more than just a ramp up. Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
…640fx.json Co-authored-by: Flo Edelmann <[email protected]>
…ash-640fx.json Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
|
@FloEdelmann Changing the matrix mapping to the table version caused the unit tests to fail. To be honest, I don't see why while comparing it to other (working) fixtures. Could you please have a look and guide me in a direction? |
|
Please also allow me to push to the branch and/or merge the latest changes from master into this branch, so that the PR can be merged (it has to be up-to-date). |
FloEdelmann
left a comment
FloEdelmann
left a comment
There was a problem hiding this comment.
Sorry, I found a few more little things in my final review 😬
After those are resolved, I can finally merge
Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
|
Once again: Please allow me to push to the branch and/or merge the latest changes from master into this branch, so that the PR can be merged (it has to be up-to-date). |
|
Hooray 🥳 |
3 participants
The following changes have been made: