Skip to content

Apply feedback for stairville/revueled-120-cob-rgbww#5104

Merged
FloEdelmann merged 5 commits intomasterfrom
fix/feedback-for-stairville-revueled-120-cob-rgbww
Sep 1, 2025
Merged

Apply feedback for stairville/revueled-120-cob-rgbww#5104
FloEdelmann merged 5 commits intomasterfrom
fix/feedback-for-stairville-revueled-120-cob-rgbww

Conversation

@luc122c
Copy link
Contributor

@luc122c luc122c commented Aug 29, 2025

Closes #5100
Closes #5101

Thank you @pade!

@luc122c luc122c requested a review from FloEdelmann August 29, 2025 22:17
@luc122c luc122c added the component-fixture Affects one or more existing fixture definitions. label Aug 29, 2025
@github-actions
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ stairville / revueled-120-cob-rgbww: d-light / attributes-correctness
  • ✔️ stairville/revueled-120-cob-rgbww-7ch.xml
✔️ stairville / revueled-120-cob-rgbww: dmxcontrol3 / channel-numbers
  • ✔️ stairville-revueled-120-cob-rgbww-7ch.xml
✔️ stairville / revueled-120-cob-rgbww: dragonframe / json-schema-conformity
  • ✔️ stairville/revueled-120-cob-rgbww.json
  • ✔️ manufacturers.json
✔️ stairville / revueled-120-cob-rgbww: millumin / json-schema-conformity
  • ✔️ stairville/revueled-120-cob-rgbww.json
✔️ stairville / revueled-120-cob-rgbww: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Stairville-RevueLED-120-COB-RGBWW.qxf
✔️ stairville / revueled-120-cob-rgbww: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Stairville-RevueLED-120-COB-RGBWW.qxf

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Plugin export diff

(Output of test script tests/github/export-diff.js.)

You can view your uncommitted changes in plugin exports manually by executing:
$ node cli/diff-plugin-outputs.js -p <plugin-key> [-c <compare-plugin-key>] <fixtures>

🆚 stairville/revueled-120-cob-rgbww: aglight
Changed outputted file aglight_fixture_library.json
--- removed
+++ added
@@ -6,11 +6,11 @@
       "name": "RevueLED 120 COB RGBWW",
       "shortName": "SVRevue120RGBWW",
       "categories": ["Color Changer"],
       "meta": {
-        "authors": ["RAZAKANIRINA"],
+        "authors": ["RAZAKANIRINA", "pade", "Luke Nelson"],
         "createDate": "2019-04-15",
-        "lastModifyDate": "2024-11-23"
+        "lastModifyDate": "2025-08-29"
       },
       "links": {
         "manual": [
           "https://images.static-thomann.de/pics/atg/atgdata/document/manual/414200_c_414200_r2_en_online.pdf"
@@ -87,27 +87,35 @@
         "Strobe": {
           "defaultValue": 0,
           "capabilities": [
             {
+              "dmxRange": [0, 9],
               "type": "ShutterStrobe",
+              "shutterEffect": "Open"
+            },
+            {
+              "dmxRange": [10, 255],
+              "type": "ShutterStrobe",
               "shutterEffect": "Strobe",
               "speedStart": 0,
-              "speedEnd": 100,
-              "helpWanted": "At which DMX value is strobe disabled? When is the lamp constantly on/off?"
+              "speedEnd": 100
             }
-          ],
-          "singleCapability": true
+          ]
         },
         "Auto Programs": {
           "defaultValue": 0,
           "capabilities": [
             {
+              "dmxRange": [0, 9],
+              "type": "NoFunction"
+            },
+            {
+              "dmxRange": [10, 255],
               "type": "Effect",
               "effectName": "Built-in automatic show programs",
-              "helpWanted": "At which DMX values can a show program be selected and when is no show active?"
+              "helpWanted": "What programs are available and at which DMX values?"
             }
-          ],
-          "singleCapability": true
+          ]
         }
       },
       "modes": [
         {
💤 stairville/revueled-120-cob-rgbww: color-chief Outputted files not changed.
🆚 stairville/revueled-120-cob-rgbww: colorsource
Changed outputted file userlib.jlib
--- removed
+++ added
@@ -116,14 +116,20 @@
           "ranges": [
             {
               "begin": 0,
               "default": 0,
+              "end": 9,
+              "label": "Shutter open"
+            },
+            {
+              "begin": 10,
+              "default": 10,
               "end": 255,
               "label": "Strobe 0…100% speed"
             }
           ],
           "size": 8,
-          "snap": false,
+          "snap": true,
           "type": 4
         },
         {
           "coarse": 6,
@@ -135,14 +141,20 @@
           "ranges": [
             {
               "begin": 0,
               "default": 0,
+              "end": 9,
+              "label": "No function"
+            },
+            {
+              "begin": 10,
+              "default": 10,
               "end": 255,
               "label": "Built-in automatic show programs"
             }
           ],
           "size": 8,
-          "snap": false,
+          "snap": true,
           "type": 4
         }
       ]
     }
🆚 stairville/revueled-120-cob-rgbww: d-light
Changed outputted file stairville/revueled-120-cob-rgbww-7ch.xml
--- removed
+++ added
@@ -66,20 +66,22 @@
         <addressIndex id="5"/>
         <parameterName id="STROBE"/>
         <minLevel id="0"/>
         <maxLevel id="255"/>
-        <Definitions index="1">
-          <name min="0" max="255" snap="0" timeHolder="0" dummy="0">Strobe 0…100% speed</name>
+        <Definitions index="2">
+          <name min="0" max="9" snap="0" timeHolder="0" dummy="0">Shutter open</name>
+          <name min="10" max="255" snap="10" timeHolder="0" dummy="0">Strobe 0…100% speed</name>
         </Definitions>
       </ThisAttribute>
       <ThisAttribute id="1">
         <HOME id="0"/>
         <addressIndex id="6"/>
         <parameterName id="AUTO_PROGRAMS"/>
         <minLevel id="0"/>
         <maxLevel id="255"/>
-        <Definitions index="1">
-          <name min="0" max="255" snap="0" timeHolder="0" dummy="0">Built-in automatic show programs</name>
+        <Definitions index="2">
+          <name min="0" max="9" snap="0" timeHolder="0" dummy="0">No function</name>
+          <name min="10" max="255" snap="10" timeHolder="0" dummy="0">Built-in automatic show programs</name>
         </Definitions>
       </ThisAttribute>
     </AttributesDefinition>
   </Attributes>
🆚 stairville/revueled-120-cob-rgbww: dmxcontrol3
Changed outputted file stairville-revueled-120-cob-rgbww-7ch.xml
--- removed
+++ added
@@ -2,9 +2,9 @@
 <device type="DMXDevice" dmxaddresscount="7" dmxcversion="3" ddfversion="dummy version by diff-plugin-outputs">
   <information>
     <model>RevueLED 120 COB RGBWW</model>
     <vendor>Stairville</vendor>
-    <author>RAZAKANIRINA</author>
+    <author>RAZAKANIRINA, pade, Luke Nelson</author>
     <mode>7-channel</mode>
   </information>
   <functions>
     <rgb>
@@ -13,12 +13,16 @@
       <blue name="Blue" dmxchannel="2"/>
       <white name="Warm White" dmxchannel="3"/>
     </rgb>
     <dimmer name="Dimmer" dmxchannel="4"/>
+    <rawstep name="Strobe" dmxchannel="5">
+      <step mindmx="0" maxdmx="9" caption="Shutter open"/>
+    </rawstep>
     <strobe name="Strobe" dmxchannel="5">
-      <range mindmx="0" maxdmx="255" minval="0" maxval="50" type="linear"/>
+      <range mindmx="10" maxdmx="255" minval="0" maxval="50" type="linear"/>
     </strobe>
     <rawstep name="Auto Programs" dmxchannel="6">
-      <step mindmx="0" maxdmx="255" caption="Built-in automatic show programs"/>
+      <step mindmx="0" maxdmx="9" caption="No function"/>
+      <step mindmx="10" maxdmx="255" caption="Built-in automatic show programs"/>
     </rawstep>
   </functions>
 </device>
\ No newline at end of file
🆚 stairville/revueled-120-cob-rgbww: dragonframe
Changed outputted file stairville/revueled-120-cob-rgbww.json
--- removed
+++ added
@@ -3,11 +3,11 @@
   "name": "RevueLED 120 COB RGBWW",
   "shortName": "SVRevue120RGBWW",
   "categories": ["Color Changer"],
   "meta": {
-    "authors": ["RAZAKANIRINA"],
+    "authors": ["RAZAKANIRINA", "pade", "Luke Nelson"],
     "createDate": "2019-04-15",
-    "lastModifyDate": "2024-11-23"
+    "lastModifyDate": "2025-08-29"
   },
   "links": {
     "manual": [
       "https://images.static-thomann.de/pics/atg/atgdata/document/manual/414200_c_414200_r2_en_online.pdf"
@@ -67,23 +67,37 @@
       }
     },
     "Strobe": {
       "defaultValue": 0,
-      "capability": {
-        "type": "ShutterStrobe",
-        "shutterEffect": "Strobe",
-        "speedStart": "0%",
-        "speedEnd": "100%",
-        "helpWanted": "At which DMX value is strobe disabled? When is the lamp constantly on/off?"
-      }
+      "capabilities": [
+        {
+          "dmxRange": [0, 9],
+          "type": "ShutterStrobe",
+          "shutterEffect": "Open"
+        },
+        {
+          "dmxRange": [10, 255],
+          "type": "ShutterStrobe",
+          "shutterEffect": "Strobe",
+          "speedStart": "0%",
+          "speedEnd": "100%"
+        }
+      ]
     },
     "Auto Programs": {
       "defaultValue": 0,
-      "capability": {
-        "type": "Effect",
-        "effectName": "Built-in automatic show programs",
-        "helpWanted": "At which DMX values can a show program be selected and when is no show active?"
-      }
+      "capabilities": [
+        {
+          "dmxRange": [0, 9],
+          "type": "NoFunction"
+        },
+        {
+          "dmxRange": [10, 255],
+          "type": "Effect",
+          "effectName": "Built-in automatic show programs",
+          "helpWanted": "What programs are available and at which DMX values?"
+        }
+      ]
     }
   },
   "modes": [
     {
🆚 stairville/revueled-120-cob-rgbww: ecue
Changed outputted file UserLibrary.xml
--- removed
+++ added
@@ -2,9 +2,9 @@
 <Document Owner="user" TypeVersion="2" SaveTimeStamp="2025-09-01#07:21:38">
     <Library>
         <Fixtures>
             <Manufacturer _CreationDate="2025-09-01#07:21:38" _ModifiedDate="2025-09-01#07:21:38" Name="Stairville" Comment="" Web="https://www.thomann.de/intl/stairville.html">
-                <Fixture _CreationDate="2019-04-15#00:00:00" _ModifiedDate="2024-11-23#00:00:00" Name="RevueLED 120 COB RGBWW" NameShort="SVRevue120RGBWW" Comment="generated by the Open Fixture Library – https://open-fixture-library.org/stairville/revueled-120-cob-rgbww" AllocateDmxChannels="7" Weight="5.5" Power="150" DimWidth="258" DimHeight="164" DimDepth="557">
+                <Fixture _CreationDate="2019-04-15#00:00:00" _ModifiedDate="2025-08-29#00:00:00" Name="RevueLED 120 COB RGBWW" NameShort="SVRevue120RGBWW" Comment="generated by the Open Fixture Library – https://open-fixture-library.org/stairville/revueled-120-cob-rgbww" AllocateDmxChannels="7" Weight="5.5" Power="150" DimWidth="258" DimHeight="164" DimDepth="557">
                     <ChannelColor Name="Red" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="1" DmxByte1="0" Constant="0" Crossfade="1" Invert="0" Precedence="LTP" ClassicPos="1">
                         <Range Name="Red off…bright" Start="0" End="255" AutoMenu="1" Centre="0"/>
                     </ChannelColor>
                     <ChannelColor Name="Green" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="2" DmxByte1="0" Constant="0" Crossfade="1" Invert="0" Precedence="LTP" ClassicPos="2">
@@ -18,13 +18,15 @@
                     </ChannelColor>
                     <ChannelIntensity Name="Dimmer" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="5" DmxByte1="0" Constant="0" Crossfade="1" Invert="0" Precedence="LTP" ClassicPos="5">
                         <Range Name="Intensity off…bright" Start="0" End="255" AutoMenu="1" Centre="0"/>
                     </ChannelIntensity>
-                    <ChannelBeam Name="Strobe" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="6" DmxByte1="0" Constant="0" Crossfade="1" Invert="0" Precedence="LTP" ClassicPos="6">
-                        <Range Name="Strobe 0…100% speed" Start="0" End="255" AutoMenu="1" Centre="0"/>
+                    <ChannelBeam Name="Strobe" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="6" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="6">
+                        <Range Name="Shutter open" Start="0" End="9" AutoMenu="1" Centre="0"/>
+                        <Range Name="Strobe 0…100% speed" Start="10" End="255" AutoMenu="1" Centre="0"/>
                     </ChannelBeam>
-                    <ChannelBeam Name="Auto Programs" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="7" DmxByte1="0" Constant="0" Crossfade="1" Invert="0" Precedence="LTP" ClassicPos="7">
-                        <Range Name="Built-in automatic show programs" Start="0" End="255" AutoMenu="1" Centre="0"/>
+                    <ChannelBeam Name="Auto Programs" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="7" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="7">
+                        <Range Name="No function" Start="0" End="9" AutoMenu="1" Centre="0"/>
+                        <Range Name="Built-in automatic show programs" Start="10" End="255" AutoMenu="1" Centre="0"/>
                     </ChannelBeam>
                 </Fixture>
             </Manufacturer>
         </Fixtures>
🆚 stairville/revueled-120-cob-rgbww: millumin
Changed outputted file stairville/revueled-120-cob-rgbww.json
--- removed
+++ added
@@ -3,11 +3,11 @@
   "name": "RevueLED 120 COB RGBWW",
   "shortName": "SVRevue120RGBWW",
   "categories": ["Color Changer"],
   "meta": {
-    "authors": ["RAZAKANIRINA"],
+    "authors": ["RAZAKANIRINA", "pade", "Luke Nelson"],
     "createDate": "2019-04-15",
-    "lastModifyDate": "2024-11-23"
+    "lastModifyDate": "2025-08-29"
   },
   "manualURL": "https://images.static-thomann.de/pics/atg/atgdata/document/manual/414200_c_414200_r2_en_online.pdf",
   "physical": {
     "dimensions": [258, 164, 557],
@@ -53,26 +53,31 @@
     },
     "Strobe": {
       "type": "Strobe",
       "defaultValue": 0,
-      "crossfade": true,
       "capabilities": [
         {
-          "range": [0, 255],
-          "name": "Strobe 0…100% speed",
-          "helpWanted": "At which DMX value is strobe disabled? When is the lamp constantly on/off?"
+          "range": [0, 9],
+          "name": "Shutter open"
+        },
+        {
+          "range": [10, 255],
+          "name": "Strobe 0…100% speed"
         }
       ]
     },
     "Auto Programs": {
       "type": "Effect",
       "defaultValue": 0,
-      "crossfade": true,
       "capabilities": [
         {
-          "range": [0, 255],
+          "range": [0, 9],
+          "name": "No function"
+        },
+        {
+          "range": [10, 255],
           "name": "Built-in automatic show programs",
-          "helpWanted": "At which DMX values can a show program be selected and when is no show active?"
+          "helpWanted": "What programs are available and at which DMX values?"
         }
       ]
     }
   },
💤 stairville/revueled-120-cob-rgbww: op-z Outputted files not changed.
🆚 stairville/revueled-120-cob-rgbww: qlcplus_4.12.2
Changed outputted file fixtures/Stairville-RevueLED-120-COB-RGBWW.qxf
--- removed
+++ added
@@ -3,9 +3,9 @@
 <FixtureDefinition xmlns="http://www.qlcplus.org/FixtureDefinition">
  <Creator>
   <Name>OFL – https://open-fixture-library.org/stairville/revueled-120-cob-rgbww</Name>
   <Version>dummy version by diff-plugin-outputs</Version>
-  <Author>RAZAKANIRINA</Author>
+  <Author>RAZAKANIRINA, pade, Luke Nelson</Author>
  </Creator>
  <Manufacturer>Stairville</Manufacturer>
  <Model>RevueLED 120 COB RGBWW</Model>
  <Type>Color Changer</Type>
@@ -13,12 +13,17 @@
  <Channel Name="Green" Preset="IntensityGreen"/>
  <Channel Name="Blue" Preset="IntensityBlue"/>
  <Channel Name="Warm White" Preset="IntensityWhite"/>
  <Channel Name="Dimmer" Preset="IntensityDimmer"/>
- <Channel Name="Strobe" Preset="ShutterStrobeSlowFast"/>
+ <Channel Name="Strobe">
+  <Group Byte="0">Shutter</Group>
+  <Capability Min="0" Max="9" Preset="ShutterOpen">Shutter open</Capability>
+  <Capability Min="10" Max="255" Preset="StrobeSlowToFast">Strobe 0…100% speed</Capability>
+ </Channel>
  <Channel Name="Auto Programs">
   <Group Byte="0">Effect</Group>
-  <Capability Min="0" Max="255">Built-in automatic show programs</Capability>
+  <Capability Min="0" Max="9">No function</Capability>
+  <Capability Min="10" Max="255">Built-in automatic show programs</Capability>
  </Channel>
  <Mode Name="7-channel">
   <Channel Number="0">Red</Channel>
   <Channel Number="1">Green</Channel>

@FloEdelmann FloEdelmann merged commit 41109f0 into master Sep 1, 2025
4 checks passed
@FloEdelmann FloEdelmann deleted the fix/feedback-for-stairville-revueled-120-cob-rgbww branch September 1, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component-fixture Affects one or more existing fixture definitions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feedback for fixture stairville/revueled-120-cob-rgbww Feedback for fixture stairville/revueled-120-cob-rgbww

2 participants