Tweaks for remote components#173
Merged
kejacobson merged 30 commits intoOpenMDAO:mainfrom Mar 24, 2025
Merged
Conversation
variable naming convention class
…them, remote DVs that don't exist on all ranks (e.g. from parallel group)
53ce6c0 to
5496d79
Compare
…ver commands, now that they work on both ranks in parallel
…oid tons of system log errors
… it to outputs_dir
…nd size 0 on ranks 1+
…t be added to compute_totals' wrt and won't use get_remote when getting its val
…fy with latest remote codes+beta
5496d79 to
079cbd3
Compare
…t_parallel supersonic panel case/use more MPhysVariables
Collaborator
|
Requires OpenMDAO PR 3465 to be merged before the CI will work again. |
kejacobson
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has a few tweaks to remote codes that I found necessary for running a new model:
In addition, a function
job_has_expiredhas been added to check if the job is no longer running before trying to run the remote analysis. This could previously happen if the job happened to expire during down time (i.e., not during a function/gradient call). For example: if two remote components are run in parallel, with one being much slower, the fast one's job could expire while the slow one is being run (or is stuck in queue), since the fast one only predicts how long its analysis might take, not how much down time there will be before the next analysis request.Also, the placeholder ssh port forwarding process was replaced by a dummy zeromq socket when holding a specific port while in queue. The prior approach worked but caused a lot of system log errors, since it was essentially setting up port forwarding with itself.