Skip to content

Conversation

@matteopilz
Copy link
Contributor

@matteopilz matteopilz commented Jul 31, 2025

Summary by CodeRabbit

  • Removed Features
    • Mass spectrometry data visualization and analysis tools, including spectrum display, scan tables, error plots, total ion chromatograms (TIC), MS1 intensity maps, and peptide sequence ion visualization, have been removed.
    • Interactive widgets for browsing scans, viewing and searching FASTA protein sequences, and loading mzTab files are no longer available.
    • File management and detection utilities for supported data types have been removed.
    • All related interactive plotting and annotation features for mass spectrometry data are no longer present.

@coderabbitai
Copy link

coderabbitai bot commented Jul 31, 2025

Walkthrough

This change deletes multiple PyQt5-based GUI widget modules and supporting classes from the src/view/ directory. The removed files include interactive visualization widgets for mass spectrometry data, file handlers, and table viewers for various proteomics formats (e.g., mzML, idXML, mzTab, FASTA). All public classes, methods, and signals in these files are removed.

Changes

Cohort / File(s) Change Summary
Mass Spectrometry Visualization Widgets
src/view/ControllerWidget.py, src/view/SpectrumWidget.py, src/view/TICWidget.py, src/view/MS1MapWidget.py, src/view/ErrorWidget.py, src/view/SequenceIonsWidget.py, src/view/ScanBrowserWidget.py, src/view/ScanTableWidget.py
All classes and methods implementing spectrum, TIC, MS1 map, error, sequence ions, scan browser, and scan table widgets are deleted, removing interactive and visualization features for mass spectrometry data.
File and Data Handlers
src/view/FilesNumberHandler.py
The class and global dictionaries for detecting, managing, and validating presence of specific file types in a directory are removed.
FASTA Viewer GUI
src/view/GUI_FastaViewer.py
The entire PyQt5-based protein FASTA file viewer, including search and display functionality, is deleted.
mzTab Table Widgets
src/view/mzTabLoadWidget.py, src/view/mzTabTableWidget.py
Classes and methods for loading, parsing, and displaying mzTab protein and PSM data in interactive tables are deleted.

Sequence Diagram(s)

No sequence diagrams generated due to the nature of the changes (complete deletions).

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~70+ minutes

Poem

In the warren of code, widgets once hopped,
Spectra and tables, all clicking nonstop.
Now the meadow is quiet, the plots packed away,
No ions or proteins to brighten the day.
But rabbits are nimble—new seeds soon will sprout,
For every old tunnel, new paths will come out!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbdfcac and afc04c3.

📒 Files selected for processing (12)
  • src/view/ControllerWidget.py (0 hunks)
  • src/view/ErrorWidget.py (0 hunks)
  • src/view/FilesNumberHandler.py (0 hunks)
  • src/view/GUI_FastaViewer.py (0 hunks)
  • src/view/MS1MapWidget.py (0 hunks)
  • src/view/ScanBrowserWidget.py (0 hunks)
  • src/view/ScanTableWidget.py (0 hunks)
  • src/view/SequenceIonsWidget.py (0 hunks)
  • src/view/SpectrumWidget.py (0 hunks)
  • src/view/TICWidget.py (0 hunks)
  • src/view/mzTabLoadWidget.py (0 hunks)
  • src/view/mzTabTableWidget.py (0 hunks)
💤 Files with no reviewable changes (12)
  • src/view/mzTabLoadWidget.py
  • src/view/SpectrumWidget.py
  • src/view/SequenceIonsWidget.py
  • src/view/ControllerWidget.py
  • src/view/MS1MapWidget.py
  • src/view/FilesNumberHandler.py
  • src/view/ScanTableWidget.py
  • src/view/ScanBrowserWidget.py
  • src/view/ErrorWidget.py
  • src/view/TICWidget.py
  • src/view/GUI_FastaViewer.py
  • src/view/mzTabTableWidget.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-test
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@matteopilz matteopilz linked an issue Jul 31, 2025 that may be closed by this pull request
@timosachsenberg
Copy link
Contributor

thanks!

@timosachsenberg timosachsenberg merged commit 2332706 into OpenMS:master Aug 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update doc to use new PeptideIdentificationList

2 participants