-
Notifications
You must be signed in to change notification settings - Fork 35
Use rq worker to schedule workflow runs #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -258,6 +258,7 @@ jobs: | |||||||||||||
|
|
||||||||||||||
| - name: Create .bat file | ||||||||||||||
| run: | | ||||||||||||||
|
|
||||||||||||||
| echo '@echo off' > ${{ env.APP_NAME }}.bat | ||||||||||||||
| echo '' >> ${{ env.APP_NAME }}.bat | ||||||||||||||
| echo 'REM Create .streamlit directory in user''s home if it doesn''t exist' >> ${{ env.APP_NAME }}.bat | ||||||||||||||
|
|
@@ -266,6 +267,8 @@ jobs: | |||||||||||||
| echo 'REM Create credentials.toml with empty email to disable email prompt' >> ${{ env.APP_NAME }}.bat | ||||||||||||||
| echo 'copy /Y ".streamlit\credentials.toml" "%USERPROFILE%\.streamlit\credentials.toml" > nul' >> ${{ env.APP_NAME }}.bat | ||||||||||||||
| echo '' >> ${{ env.APP_NAME }}.bat | ||||||||||||||
| echo 'start /min .\python-${{ env.PYTHON_VERSION }}\python -m redis-server' > ${{ env.APP_NAME }}.bat | ||||||||||||||
| echo 'start /min .\python-${{ env.PYTHON_VERSION }}\python -m rq worker --with-scheduler' >> ${{ env.APP_NAME }}.bat | ||||||||||||||
| echo 'start /min .\python-${{ env.PYTHON_VERSION }}\python -m streamlit run app.py local' >> ${{ env.APP_NAME }}.bat | ||||||||||||||
|
Comment on lines
+270
to
272
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prevent Accidental File Overwrite with Correct Redirection In the updated batch file section, the command on line 270 uses the single redirection operator ( Below is the suggested fix: -echo 'start /min .\python-${{ env.PYTHON_VERSION }}\python -m redis-server' > ${{ env.APP_NAME }}.bat
+echo 'start /min .\python-${{ env.PYTHON_VERSION }}\python -m redis-server' >> ${{ env.APP_NAME }}.bat 📝 Committable suggestion
Suggested change
🧰 Tools🪛 YAMLlint (1.35.1)[error] 270-270: trailing spaces (trailing-spaces) |
||||||||||||||
|
|
||||||||||||||
| - name: Create All-in-one executable folder | ||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove extra space