Skip to content

fix : Workflows are not terminated if errors are detected #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asterisk-ragavan wants to merge 2 commits into from
Closed

fix : Workflows are not terminated if errors are detected #163

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1b92be
fix : Workflows are not terminated if errors are detected
asterisk-ragavan Mar 7, 2025
af7e264
this will stop all the thread with the stop signal, also revert back…
asterisk-ragavan Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/workflow/CommandExecutor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ def run_command(self, command: list[str]) -> None:
if stderr or process.returncode != 0:
error_message = stderr.decode().strip()
self.logger.log(f"ERRORS OCCURRED:\n{error_message}", 2)
raise RuntimeError(f"Process failed: {error_message}")

def run_topp(self, tool: str, input_output: dict, custom_params: dict = {}) -> None:
"""
Expand Down
2 changes: 1 addition & 1 deletion src/workflow/WorkflowManager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def workflow_process(self) -> None:
self.execution()
self.logger.log("WORKFLOW FINISHED")
except Exception as e:
self.logger.log(f"ERROR: {e}")
self.logger.log(f"ERROR: {str(e).splitlines()[0].strip()}")
# Delete pid dir path to indicate workflow is done
shutil.rmtree(self.executor.pid_dir, ignore_errors=True)

Expand Down
Loading