Handle params.json as copyable file instead of symlink#325
Merged
t0mdavid-m merged 2 commits intomainfrom Jan 28, 2026
Merged
Conversation
When copying demo files on Linux, params.json is now copied as a regular file instead of being symlinked. This allows the params.json file to be modified independently of the source demo data. https://claude.ai/code/session_012dUQQTySG19toAR3FH7xme
.ini files contain TOPP tool parameter configurations that users may modify. Like params.json, these should be copied rather than symlinked to prevent users from affecting each other in multi-user environments. https://claude.ai/code/session_012dUQQTySG19toAR3FH7xme
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughChanges to Changes
Possibly related PRs
Poem
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modified the file handling logic to copy
params.jsoninstead of symlinking it, allowing users to modify workspace-specific parameters independently without affecting the original source files.Key Changes
_symlink_tree()function to detectparams.jsonand copy it usingshutil.copy2()instead of creating a symlinkchange_workspace()function to excludeparams.jsonfrom symlink creation on Linux systems, falling back to copy behavior insteadparams.jsonreceives special handlingImplementation Details
params.jsonis copied with metadata preservation (shutil.copy2()) rather than symlinked_symlink_tree) and workspace switching (change_workspace)https://claude.ai/code/session_012dUQQTySG19toAR3FH7xme
Summary by CodeRabbit
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.