Fix HEADERS ALREADY SENT from Mage_Core_Block_Template (#2978)

luigifab · fballiano · fballiano · commit 4f93dbd40413 · 2023-02-01T09:36:56.000Z
Co-authored-by: Fabrizio Balliano &lt;fabrizio.balliano@gmail.com&gt;
diff --git a/app/code/core/Mage/Core/Block/Template.php b/app/code/core/Mage/Core/Block/Template.php
@@ -260,7 +260,10 @@ public function fetchView($fileName)
                 Mage::log('Not valid template file:' . $fileName . ' class: ' . $thisClass, Zend_Log::CRIT, null, true);
             }
         } catch (Throwable $e) {
-            ob_get_clean();
+            if (!$do) {
+                ob_get_clean();
+                $do = true;
+            }
             if (Mage::getIsDeveloperMode()) {
                 throw $e;
             }

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,10 @@ public function fetchView($fileName)`
`260`	`260`	`Mage::log('Not valid template file:' . $fileName . ' class: ' . $thisClass, Zend_Log::CRIT, null, true);`
`261`	`261`	`}`
`262`	`262`	`} catch (Throwable $e) {`
`263`		`- ob_get_clean();`
	`263`	`+ if (!$do) {`
	`264`	`+ ob_get_clean();`
	`265`	`+ $do = true;`
	`266`	`+ }`
`264`	`267`	`if (Mage::getIsDeveloperMode()) {`
`265`	`268`	`throw $e;`
`266`	`269`	`}`