Skip to content

Commit 80cc6cc

Browse files
authored
rector: RemoveReflectionSetAccessibleCallsRector (#4952)
* rector: `RemoveReflectionSetAccessibleCallsRector` And move `ReflectionMethod` into extra function * Update MysqlTest.php
1 parent f31e568 commit 80cc6cc

File tree

1 file changed

+18
-46
lines changed

1 file changed

+18
-46
lines changed

tests/unit/Varien/Db/Adapter/Pdo/MysqlTest.php

Lines changed: 18 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,8 @@ protected function setUp(): void
4646
*/
4747
public function testGetHostInfoWithUnixSocket(): void
4848
{
49-
$method = new ReflectionMethod(Varien_Db_Adapter_Pdo_Mysql::class, '_getHostInfo');
50-
$method->setAccessible(true);
51-
5249
$fakeSocket = '/var/run/mysqld/mysqld.sock';
53-
54-
/** @var Varien_Object $hostInfo */
55-
$hostInfo = $method->invoke($this->adapter, $fakeSocket);
50+
$hostInfo = $hostInfo = $this->getHostInfo($fakeSocket);
5651

5752
self::assertSame(Varien_Db_Adapter_Pdo_Mysql::ADDRESS_TYPE_UNIX_SOCKET, $hostInfo->getAddressType());
5853
self::assertSame($fakeSocket, $hostInfo->getUnixSocket());
@@ -65,11 +60,7 @@ public function testGetHostInfoWithUnixSocket(): void
6560
*/
6661
public function testGetHostInfoWithIpv4Address(): void
6762
{
68-
$method = new ReflectionMethod(Varien_Db_Adapter_Pdo_Mysql::class, '_getHostInfo');
69-
$method->setAccessible(true);
70-
71-
/** @var Varien_Object $hostInfo */
72-
$hostInfo = $method->invoke($this->adapter, '192.168.1.1:3306');
63+
$hostInfo = $this->getHostInfo('192.168.1.1:3306');
7364

7465
self::assertSame(Varien_Db_Adapter_Pdo_Mysql::ADDRESS_TYPE_IPV4_ADDRESS, $hostInfo->getAddressType());
7566
self::assertSame('192.168.1.1', $hostInfo->getHostName());
@@ -82,11 +73,7 @@ public function testGetHostInfoWithIpv4Address(): void
8273
*/
8374
public function testGetHostInfoWithIpv4AddressWithoutPort(): void
8475
{
85-
$method = new ReflectionMethod(Varien_Db_Adapter_Pdo_Mysql::class, '_getHostInfo');
86-
$method->setAccessible(true);
87-
88-
/** @var Varien_Object $hostInfo */
89-
$hostInfo = $method->invoke($this->adapter, '192.168.1.1');
76+
$hostInfo = $this->getHostInfo('192.168.1.1');
9077

9178
self::assertSame(Varien_Db_Adapter_Pdo_Mysql::ADDRESS_TYPE_IPV4_ADDRESS, $hostInfo->getAddressType());
9279
self::assertSame('192.168.1.1', $hostInfo->getHostName());
@@ -99,11 +86,7 @@ public function testGetHostInfoWithIpv4AddressWithoutPort(): void
9986
*/
10087
public function testGetHostInfoWithHostname(): void
10188
{
102-
$method = new ReflectionMethod(Varien_Db_Adapter_Pdo_Mysql::class, '_getHostInfo');
103-
$method->setAccessible(true);
104-
105-
/** @var Varien_Object $hostInfo */
106-
$hostInfo = $method->invoke($this->adapter, 'db.example.com:3306');
89+
$hostInfo = $this->getHostInfo('db.example.com:3306');
10790

10891
self::assertSame(Varien_Db_Adapter_Pdo_Mysql::ADDRESS_TYPE_HOSTNAME, $hostInfo->getAddressType());
10992
self::assertSame('db.example.com', $hostInfo->getHostName());
@@ -116,11 +99,7 @@ public function testGetHostInfoWithHostname(): void
11699
*/
117100
public function testGetHostInfoWithHostnameWithoutPort(): void
118101
{
119-
$method = new ReflectionMethod(Varien_Db_Adapter_Pdo_Mysql::class, '_getHostInfo');
120-
$method->setAccessible(true);
121-
122-
/** @var Varien_Object $hostInfo */
123-
$hostInfo = $method->invoke($this->adapter, 'db.example.com');
102+
$hostInfo = $this->getHostInfo('db.example.com');
124103

125104
self::assertSame(Varien_Db_Adapter_Pdo_Mysql::ADDRESS_TYPE_HOSTNAME, $hostInfo->getAddressType());
126105
self::assertSame('db.example.com', $hostInfo->getHostName());
@@ -133,11 +112,7 @@ public function testGetHostInfoWithHostnameWithoutPort(): void
133112
*/
134113
public function testGetHostInfoWithIpv6Address(): void
135114
{
136-
$method = new ReflectionMethod(Varien_Db_Adapter_Pdo_Mysql::class, '_getHostInfo');
137-
$method->setAccessible(true);
138-
139-
/** @var Varien_Object $hostInfo */
140-
$hostInfo = $method->invoke($this->adapter, '[2001:db8::1]:3306');
115+
$hostInfo = $this->getHostInfo('[2001:db8::1]:3306');
141116

142117
self::assertSame(Varien_Db_Adapter_Pdo_Mysql::ADDRESS_TYPE_IPV6_ADDRESS, $hostInfo->getAddressType());
143118
self::assertSame('2001:db8::1', $hostInfo->getHostName());
@@ -150,11 +125,7 @@ public function testGetHostInfoWithIpv6Address(): void
150125
*/
151126
public function testGetHostInfoWithIpv6AddressWithoutPort(): void
152127
{
153-
$method = new ReflectionMethod(Varien_Db_Adapter_Pdo_Mysql::class, '_getHostInfo');
154-
$method->setAccessible(true);
155-
156-
/** @var Varien_Object $hostInfo */
157-
$hostInfo = $method->invoke($this->adapter, '2001:db8::1');
128+
$hostInfo = $this->getHostInfo('2001:db8::1');
158129

159130
self::assertSame(Varien_Db_Adapter_Pdo_Mysql::ADDRESS_TYPE_IPV6_ADDRESS, $hostInfo->getAddressType());
160131
self::assertSame('2001:db8::1', $hostInfo->getHostName());
@@ -167,11 +138,7 @@ public function testGetHostInfoWithIpv6AddressWithoutPort(): void
167138
*/
168139
public function testGetHostInfoWithIpv6AddressWithZoneId(): void
169140
{
170-
$method = new ReflectionMethod(Varien_Db_Adapter_Pdo_Mysql::class, '_getHostInfo');
171-
$method->setAccessible(true);
172-
173-
/** @var Varien_Object $hostInfo */
174-
$hostInfo = $method->invoke($this->adapter, '[fe80::1%eth0]:3306');
141+
$hostInfo = $this->getHostInfo('[fe80::1%eth0]:3306');
175142

176143
self::assertSame(Varien_Db_Adapter_Pdo_Mysql::ADDRESS_TYPE_IPV6_ADDRESS, $hostInfo->getAddressType());
177144
self::assertSame('fe80::1%eth0', $hostInfo->getHostName());
@@ -184,15 +151,20 @@ public function testGetHostInfoWithIpv6AddressWithZoneId(): void
184151
*/
185152
public function testGetHostInfoWithIpv6AddressWithZoneIdWithoutPort(): void
186153
{
187-
$method = new ReflectionMethod(Varien_Db_Adapter_Pdo_Mysql::class, '_getHostInfo');
188-
$method->setAccessible(true);
189-
190-
/** @var Varien_Object $hostInfo */
191-
$hostInfo = $method->invoke($this->adapter, 'fe80::1%eth0');
154+
$hostInfo = $this->getHostInfo('fe80::1%eth0');
192155

193156
self::assertSame(Varien_Db_Adapter_Pdo_Mysql::ADDRESS_TYPE_IPV6_ADDRESS, $hostInfo->getAddressType());
194157
self::assertSame('fe80::1%eth0', $hostInfo->getHostName());
195158
self::assertNull($hostInfo->getPort());
196159
self::assertNull($hostInfo->getUnixSocket());
197160
}
161+
162+
private function getHostInfo(string $str): Varien_Object
163+
{
164+
$method = new ReflectionMethod(Varien_Db_Adapter_Pdo_Mysql::class, '_getHostInfo');
165+
166+
/** @var Varien_Object $hostInfo */
167+
$hostInfo = $method->invoke($this->adapter, $str);
168+
return $hostInfo;
169+
}
198170
}

0 commit comments

Comments
 (0)