Make php-8.1 minimum requirement#4124
Merged
addison74 merged 31 commits intoOpenMage:mainfrom Mar 12, 2025
Merged
Conversation
* Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164
This reverts commit 3d7eaf6.
- updated workflows - phpstan baseline (will be fixed later)
github-actions
bot
added
environment
composer
sreichel
changed the title
php-8.,0 minimum requirementphp-8.0 minimum requirement
kiatng
reviewed
Aug 7, 2024
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
# Conflicts: # composer.lock # phpstan.dist.baseline.neon
github-actions
bot
added
Component: lib/Varien
sreichel
changed the title
php-8.0 minimum requirementphp-8.1 minimum requirement
addison74
previously approved these changes
Sep 5, 2024
Member
|
Agreed with the changes, but I believe this should be in "next" so that it is in the next major version update.
Since v21 was not released yet this could still make it into v21. EDIT: Just saw there is already #3920 |
Contributor
Author
|
@colinmollenhour its on draft, b/c we should think about to raise minimum version for main branch too. |
# Conflicts: # .github/workflows/phpstan.yml # .github/workflows/sonar.yml # .github/workflows/syntax-php.yml # app/code/core/Mage/Media/Model/File/Image.php # composer.json # composer.lock # phpstan.dist.baseline.neon
github-actions
bot
removed
Component: Dataflow
addison74
previously approved these changes
Mar 11, 2025
# Conflicts: # composer.lock
addison74
previously approved these changes
Mar 11, 2025
|
colinmollenhour
approved these changes
Mar 12, 2025
Member
colinmollenhour
left a comment
colinmollenhour
left a comment
There was a problem hiding this comment.
Nice work @sreichel !
addison74
approved these changes
Mar 12, 2025
fballiano
added a commit
to MahoCommerce/maho
that referenced
this pull request
Mar 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We removed 7.3 support in 03/2003 ... now - plus one year later - its time to make the next step.
PHP8 offers a lot of good features, i'd like to use when writing extension but i am limited due to php7 support.
Worth a read ... https://accesto.com/blog/php-performance-improvement-features/
According to packagist.org stats only 20% still use php7.4 with latest releases.
https://packagist.org/packages/openmage/magento-lts/php-stats#20.10
Note 1: If you have modules/extensions that dont work with php8, drop me a note! This should be no reason to stay on an old php version!
Note 2: OpenMage will still proberly work with older versions too - as long we not introduce backwards-incomaptible changes.
Note3 : with https://github.com/rectorphp/rector you have a tool to refactor your code for php8.