Skip to content

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 9, 2024

Description (*)

Work in progress ...

(some lines are only for testing and have to be removed)

  • updates tests to test agains DB
  • fixes Mage::getStoreConfig()
  • fixes override existing DB values
  • locked attributes in system config

Broken ...

  • unittests for non-existing stores/websites (?)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Set php ENV variables ... for DDEV (to match tests)

web_environment:
    - OPENMAGE_CONFIG__DEFAULT__GENERAL__STORE_INFORMATION__NAME=ENV default
    - OPENMAGE_CONFIG__DEFAULT__GENERAL__FOO-BAR__NAME=ENV default dashes
    - OPENMAGE_CONFIG__DEFAULT__GENERAL__FOO_BAR__NAME=ENV default underscore
    - OPENMAGE_CONFIG__DEFAULT__GENERAL__ST=ENV default invalid
    - OPENMAGE_CONFIG__WEBSITES__BASE__GENERAL__STORE_INFORMATION__NAME=ENV website
    - OPENMAGE_CONFIG__WEBSITES__BASE-AT__GENERAL__STORE_INFORMATION__NAME=ENV website dashes
    - OPENMAGE_CONFIG__WEBSITES__BASE_CH__GENERAL__STORE_INFORMATION__NAME=ENV website underscore
    - OPENMAGE_CONFIG__WEBSITES__BASE__GENERAL__ST=ENV website invalid
    - OPENMAGE_CONFIG__STORES__GERMAN__GENERAL__STORE_INFORMATION__NAME=ENV store
    - OPENMAGE_CONFIG__STORES__GERMAN-AT__GENERAL__STORE_INFORMATION__NAME=ENV store dashes
    - OPENMAGE_CONFIG__STORES__GERMAN_CH__GENERAL__STORE_INFORMATION__NAME=ENV store underscore
    - OPENMAGE_CONFIG__STORES__GERMAN__GENERAL__ST=ENV store invalid

Comments

This is not nearly perfect, but may help others to debug.

@pquerner @boesbo please check.

@github-actions github-actions bot added Component: Core Relates to Mage_Core Component: lib/Varien Relates to lib/Varien Component: Adminhtml Relates to Mage_Adminhtml Component: lib/* Relates to lib/* phpunit labels Oct 9, 2024
@sreichel sreichel marked this pull request as draft October 9, 2024 07:02
@sreichel
Copy link
Contributor Author

sreichel commented Oct 9, 2024

Will re-open later ...

@pquerner
Copy link
Contributor

pquerner commented Feb 8, 2025

Sorry I havent seen this one. Your solution seem elegant to use, however I think its not quite working for me.
image
I expected it would show [ENV] here, but it did not.
The field however, is disabled. I havent debugged it yet, because I was working on #4617 .

Perhaps it could be glued together with #4617

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Core Relates to Mage_Core Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* phpstan phpunit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants