Skip to content

Updated phpstan to v2.1 #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 5, 2025
Merged

Updated phpstan to v2.1 #4430

merged 10 commits into from
Jan 5, 2025

Conversation

sreichel
Copy link
Contributor

No changes. Only updated baseline for new format.

@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog composer Relates to composer.json phpstan labels Dec 25, 2024
@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Cms Relates to Mage_Cms Component: Reports Relates to Mage_Reports Component: lib/Varien Relates to lib/Varien Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: lib/Mage Relates to lib/Mage Component: Adminhtml Relates to Mage_Adminhtml Component: Page Relates to Mage_Page Component: Api PageRelates to Mage_Api Component: SalesRule Relates to Mage_SalesRule Component: Wishlist Relates to Mage_Wishlist Component: Shipping Relates to Mage_Shipping Component: Oauth Relates to Mage_Oauth Component: Downloadable Relates to Mage_Downloadable Component: Api2 Relates to Mage_Api2 Component: Media Relates to Mage_Media Component: ImportExport Relates to Mage_ImportExport Component: Directory Relates to Mage_Directory Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches labels Dec 25, 2024
@github-actions github-actions bot added Component: Dataflow Relates to Mage_Dataflow Component: Install Relates to Mage_Install Component: Uploader Relates to Mage_Uploader Component: lib/* Relates to lib/* labels Dec 25, 2024
@sreichel sreichel requested review from kiatng and addison74 December 30, 2024 09:40
@sreichel
Copy link
Contributor Author

We should complete this befor working on #4411..

addison74
addison74 previously approved these changes Dec 30, 2024
View reviewed changes
@sreichel sreichel added this to the 20.12.0 milestone Jan 1, 2025
@sreichel sreichel changed the title Updated phpstan to v2 Updated phpstan to v2.1 Jan 1, 2025
@sreichel sreichel requested a review from addison74 January 1, 2025 23:59
@sreichel sreichel merged commit db20784 into OpenMage:main Jan 5, 2025
14 of 19 checks passed
@sreichel sreichel deleted the phpstan-v2 branch January 5, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@addison74 addison74 addison74 approved these changes

Assignees
No one assigned
Labels
chore Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: Install Relates to Mage_Install Component: lib/Mage Relates to lib/Mage Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Media Relates to Mage_Media Component: Oauth Relates to Mage_Oauth Component: Page Relates to Mage_Page Component: PayPal Relates to Mage_Paypal Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Shipping Relates to Mage_Shipping Component: Uploader Relates to Mage_Uploader Component: Usa Relates to Mage_Usa Component: Wishlist Relates to Mage_Wishlist composer Relates to composer.json phpstan
Projects
None yet
Milestone
20.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @kiatng @addison74