-
-
Notifications
You must be signed in to change notification settings - Fork 449
Fix missing TinyMCE license files + tests #4959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
(it will fail for v8)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Ensures TinyMCE license files are present and verified by unit tests; bumps composer plugin to pick up related install behaviors.
- Add PHPUnit tests to assert presence of TinyMCE license files in project root and vendor directory.
- Update dependency constraint openmage/composer-plugin from ^3.0 to ^3.1.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tests/unit/Base/TinyMCELicenseTest.php | Adds tests that check for TinyMCE license files; uses Composer InstalledVersions to gate tests. |
composer.json | Bumps openmage/composer-plugin to ^3.1. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
(it will fail for v8)
edit: composer-plugin added license-files for TinyMCE v7.x, but not for v8.x (or later). Fixed in v3.1.