Skip to content

Fix cURL error description retrieval #4965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −7
Open

Fix cURL error description retrieval #4965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e55fe8
Fix cURL error description retrieval
sreichel Oct 3, 2025
b9a83c8
Remove outdated curl_strerror error message
sreichel Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .phpstan.dist.baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5076,12 +5076,6 @@ parameters:
count: 18
path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php

-
rawMessage: 'Parameter #1 $error_code of function curl_strerror expects int, (CurlHandle|false) given.'
identifier: argument.type
count: 1
path: app/code/core/Mage/Usa/Model/Shipping/Carrier/UpsAuth.php

-
rawMessage: 'Parameter #3 $value of function curl_setopt expects bool, int given.'
identifier: argument.type
Expand Down
2 changes: 1 addition & 1 deletion app/code/core/Mage/Usa/Model/Shipping/Carrier/UpsAuth.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public function getAccessToken(string $clientId, string $clientSecret, string $c
try {
if ($responseData === false) {
$code = curl_errno($ch);
$description = curl_strerror($ch);
$description = curl_strerror($code);
$message = curl_error($ch);
Mage::throwException("cURL Error: ($code) $description - \"$message\"");
}
Expand Down
Loading