Skip to content

Bug: Call to an undefined method in Mage_Tax_Model_Config_Price_Include #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bug: Call to an undefined method in Mage_Tax_Model_Config_Price_Include #5097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f764162
Bug: Call to an undefined method in `Mage_Tax_Model_Config_Price_Incl…
sreichel Nov 14, 2025
630b6e8
Merge branch 'main' into fix/after-save
sreichel Nov 16, 2025
1d1236b
Merge branch 'main' into fix/after-save
sreichel Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .phpstan.dist.baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2766,12 +2766,6 @@ parameters:
count: 1
path: app/code/core/Mage/Tax/Helper/Data.php

-
rawMessage: 'Call to an undefined static method Mage_Core_Model_Config_Data::afterSave().'
identifier: staticMethod.notFound
count: 1
path: app/code/core/Mage/Tax/Model/Config/Price/Include.php

-
rawMessage: 'Strict comparison using === between non-empty-list and array{} will always evaluate to false.'
identifier: identical.alwaysFalse
Expand Down
2 changes: 1 addition & 1 deletion app/code/core/Mage/Tax/Model/Config/Price/Include.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class Mage_Tax_Model_Config_Price_Include extends Mage_Core_Model_Config_Data
{
public function afterSave()
{
parent::afterSave();
parent::_afterSave();
Mage::app()->cleanCache('checkout_quote');
}
Comment on lines 15 to 19
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method signature should be protected function _afterSave() instead of public function afterSave(). In the Magento lifecycle, _afterSave() is the protected hook method that gets called automatically during the save process. Other Config_Data subclasses (like Mage_Adminhtml_Model_System_Config_Backend_Cache) follow this pattern by overriding protected function _afterSave(). The current implementation creates a public method that won't be called by the framework's save lifecycle.

Copilot uses AI. Check for mistakes.
}
Loading