Skip to content

phpstan: fix comparison for get_object_vars #5271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sreichel merged 1 commit into from
Feb 16, 2026
Merged

phpstan: fix comparison for get_object_vars #5271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 6 additions & 36 deletions .phpstan.dist.baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3300,36 +3300,12 @@ parameters:
count: 4
path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api.php

-
rawMessage: 'Strict comparison using !== between array<string, mixed> and null will always evaluate to true.'
identifier: notIdentical.alwaysTrue
count: 2
path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php

-
rawMessage: Unreachable statement - code above always terminates.
identifier: deadCode.unreachable
count: 1
path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php

-
rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
identifier: empty.notAllowed
count: 4
path: app/code/core/Mage/Checkout/Model/Cart/Payment/Api.php

-
rawMessage: 'Strict comparison using !== between array<string, mixed> and null will always evaluate to true.'
identifier: notIdentical.alwaysTrue
count: 1
path: app/code/core/Mage/Checkout/Model/Cart/Payment/Api/V2.php

-
rawMessage: Unreachable statement - code above always terminates.
identifier: deadCode.unreachable
count: 1
path: app/code/core/Mage/Checkout/Model/Cart/Payment/Api/V2.php

-
rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
identifier: empty.notAllowed
Expand Down Expand Up @@ -4458,18 +4434,6 @@ parameters:
count: 1
path: app/code/core/Mage/Customer/Model/Customer.php

-
rawMessage: 'Strict comparison using !== between array<string, mixed> and null will always evaluate to true.'
identifier: notIdentical.alwaysTrue
count: 1
path: app/code/core/Mage/Customer/Model/Customer/Api/V2.php

-
rawMessage: Unreachable statement - code above always terminates.
identifier: deadCode.unreachable
count: 1
path: app/code/core/Mage/Customer/Model/Customer/Api/V2.php

-
rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
identifier: empty.notAllowed
Expand Down Expand Up @@ -7584,6 +7548,12 @@ parameters:
count: 1
path: app/code/core/Mage/Weee/Model/Tax.php

-
rawMessage: If condition is always false.
identifier: if.alwaysFalse
count: 1
path: app/code/core/Mage/Weee/Model/Total/Quote/Weee.php

-
rawMessage: PHPDoc type Mage_Weee_Helper_Data of property Mage_Weee_Model_Total_Quote_Weee::$_helper is not the same as PHPDoc type Mage_Tax_Helper_Data of overridden property Mage_Tax_Model_Sales_Total_Quote_Tax::$_helper.
identifier: property.phpDocType
Expand Down
4 changes: 2 additions & 2 deletions app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class Mage_Checkout_Model_Cart_Customer_Api_V2 extends Mage_Checkout_Model_Cart_
*/
protected function _prepareCustomerData($data)
{
if (($_data = get_object_vars($data)) !== null) {
if (($_data = get_object_vars($data)) !== []) {
return parent::_prepareCustomerData($_data);
}

Expand All @@ -40,7 +40,7 @@ protected function _prepareCustomerAddressData($data)
if (is_array($data)) {
$dataAddresses = [];
foreach ($data as $addressItem) {
if (($_addressItem = get_object_vars($addressItem)) !== null) {
if (($_addressItem = get_object_vars($addressItem)) !== []) {
$dataAddresses[] = $_addressItem;
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/code/core/Mage/Checkout/Model/Cart/Payment/Api/V2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Mage_Checkout_Model_Cart_Payment_Api_V2 extends Mage_Checkout_Model_Cart_P
*/
protected function _preparePaymentData($data)
{
if (($_data = get_object_vars($data)) !== null) {
if (($_data = get_object_vars($data)) !== []) {
return parent::_preparePaymentData($_data);
}

Expand Down
2 changes: 1 addition & 1 deletion app/code/core/Mage/Customer/Model/Customer/Api/V2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class Mage_Customer_Model_Customer_Api_V2 extends Mage_Customer_Model_Customer_A
*/
protected function _prepareData($data)
{
if (($objectVars = get_object_vars($data)) !== null) {
if (($objectVars = get_object_vars($data)) !== []) {
return parent::_prepareData($objectVars);
}

Expand Down
Loading