Skip to content

Conversation

@matthew-brett
Copy link
Contributor

The command as merged used the compiler target as the compiler path.

I have run and tested a build with this command.

@MugundanMCW - is this correct?

The command as merged uses the compiler target as the compiler path.

I have run and tested a build with this command.

@MugundanMCW - is this correct?
@MugundanMCW
Copy link

The command as merged used the compiler target as the compiler path.

I have run and tested a build with this command.

@MugundanMCW - is this correct?

Yes, it's true that the command as merged, uses the compiler target as the compiler path. Adding "_TARGET" to specify the compiler target would be the correct fix else would leads to error.

Thanks

@martin-frbg
Copy link
Collaborator

Can either of you confirm that the cmake_c_compiler_target option is actually required in this context ? In my experience, it seems to compile just fine without, which seems to agree with a comment in the cmake documentation that suggests that clang should be able to figure it out on its own.

@martin-frbg martin-frbg merged commit 5930c16 into OpenMathLib:develop Jan 24, 2025
81 of 85 checks passed
@matthew-brett
Copy link
Contributor Author

I can confirm the command runs without error without the _TARGET defines, and the tests pass, on a native WoA system.

dumpbin /headers lib\Release\openblas.lib | findstr /i machine

confirms these are AA64 binaries.

@MugundanMCW
Copy link

I can confirm the command run

Yes, it's true that the CMake setup can automatically detect clang-cl on a native WoA system, even without the target flag.

@martin-frbg
Copy link
Collaborator

Thanks for confirming this. So, do we really want to present redundant options that are likely to be misspelled and that will make the compilation look less straightforward than it actually is on WoA ?

@MugundanMCW
Copy link

@martin-frbg yes, the following command could be sufficient to compile OpenBLAS for WoA without any errors:
cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Release -DTARGET=ARMV8 -DBINARY=64 -DCMAKE_C_COMPILER=clang-cl -DCMAKE_Fortran_COMPILER=flang-new

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants