Skip to content

Fixes for some gcc warnings #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-frbg merged 3 commits into from
Jul 19, 2025
Merged

Fixes for some gcc warnings #5386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3df503c
portability fix and cleanup
martin-frbg Jul 18, 2025
38e6999
format cleanup
martin-frbg Jul 18, 2025
30dbca5
fix misleading indentation to silence a gcc warning
martin-frbg Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions interface/lapack/trtri.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,10 @@ int NAME(char *UPLO, char *DIAG, blasint *N, FLOAT *a, blasint *ldA, blasint *In
#endif

#ifdef SMP
if (args.n <= 150)
args.nthreads = 1;
else
args.nthreads = num_cpu_avail(4);
if (args.n <= 150)
args.nthreads = 1;
else
args.nthreads = num_cpu_avail(4);

if (args.nthreads == 1) {
#endif
Expand Down
8 changes: 6 additions & 2 deletions test/compare_sgemm_bgemm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,18 @@ main (int argc, char *argv[])
float16to32 (AA[k * j + l]) * float16to32 (BB[i + l * n]);
}
if (!is_close(float16to32(CC[i * m + j]), truncate_float32_to_bfloat16(C[i * m + j]), 0.01, 0.001)) {
printf("Mismatch at i=%d, j=%d, k=%d: CC=%.6f, C=%.6f\n",
#ifdef DEBUG
printf("Mismatch at i=%d, j=%d, k=%ld: CC=%.6f, C=%.6f\n",
i, j, k, float16to32(CC[i * m + j]), truncate_float32_to_bfloat16(C[i * m + j]));
#endif
ret++;
}

if (!is_close(float16to32(CC[i * m + j]), truncate_float32_to_bfloat16(DD[i * m + j]), 0.0001, 0.00001)) {
printf("Mismatch at i=%d, j=%d, k=%d: CC=%.6f, DD=%.6f\n",
#ifdef DEBUG
printf("Mismatch at i=%d, j=%d, k=%ld: CC=%.6f, DD=%.6f\n",
i, j, k, float16to32(CC[i * m + j]), truncate_float32_to_bfloat16(DD[i * m + j]));
#endif
ret++;
}

Expand Down
10 changes: 7 additions & 3 deletions test/compare_sgemv_bgemv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ int main(int argc, char *argv[])
SGEMV(&transA, &x, &x, &alpha, A, &x, B, &k, &beta, C, &k);
BGEMV(&transA, &x, &x, &alpha_bf16, AA, &x, BB, &k, &beta_bf16, CC, &k);

for (int i = 0; i < x; i++)
for (i = 0; i < x; i++)
DD[i] *= beta;

for (j = 0; j < x; j++)
Expand All @@ -118,14 +118,18 @@ int main(int argc, char *argv[])
{
if (!is_close(float16to32(CC[j << l]), truncate_float32_to_bfloat16(C[j << l]), 0.01, 0.001))
{
printf("Mismatch at trans=%c, alpha=%.2f, beta=%.2f, i=%d, j=%d, k=%d: CC=%.6f, C=%.6f\n",
#ifdef DEBUG
printf("Mismatch at trans=%c, alpha=%.2f, beta=%.2f, i=%d, j=%d, k=%ld: CC=%.6f, C=%.6f\n",
transA, alpha, beta, i, j, k, float16to32(CC[j << l]), truncate_float32_to_bfloat16(C[j << l]));
#endif
ret++;
}
if (!is_close(float16to32(CC[j << l]), truncate_float32_to_bfloat16(DD[j]), 0.001, 0.0001))
{
printf("Mismatch at trans=%c, alpha=%.2f, beta=%.2f, i=%d, j=%d, k=%d: CC=%.6f, C=%.6f\n",
#ifdef DEBUG
printf("Mismatch at trans=%c, alpha=%.2f, beta=%.2f, i=%d, j=%d, k=%ld: CC=%.6f, C=%.6f\n",
transA, alpha, beta, i, j, k, float16to32(CC[j << l]), truncate_float32_to_bfloat16(DD[j]));
#endif
ret++;
}
}
Expand Down
Loading