CMake: Demote the OpenMP mixed linkage check to NOTICE #5434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywwry66
changed the title
ywwry66
force-pushed
the
mixed_openmp_warning
branch
from
d8cbde6 to
102f734
Compare
ywwry66
force-pushed
the
mixed_openmp_warning
branch
2 times, most recently
from
d9cfe99 to
aeae37e
Compare
|
In view of the false positives mentioned in #5412, it makes more sense to further demote the check to a CMake |
ywwry66
changed the title
ywwry66
force-pushed
the
mixed_openmp_warning
branch
from
aeae37e to
303c317
Compare
ywwry66
force-pushed
the
mixed_openmp_warning
branch
from
303c317 to
ed6c223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5412 and #5413. If preferred, we can also remove the check altogether.