Fix bf16->f32 conversion for NEOVERSEV1 and NEOVERSEN2 targets#5483
Merged
martin-frbg merged 2 commits intoOpenMathLib:developfrom Oct 7, 2025
Merged
Fix bf16->f32 conversion for NEOVERSEV1 and NEOVERSEN2 targets#5483martin-frbg merged 2 commits intoOpenMathLib:developfrom
martin-frbg merged 2 commits intoOpenMathLib:developfrom
Conversation
Mousius
force-pushed
the
bgemm-correctness
branch
2 times, most recently
from
5da3bd0 to
5b54afe
Compare
This fixes an issue originally introduced with the BGEMM kernel. I've updated the tests to run with `beta=1.0` so as to test loading and updating from C. Alongside this, the tests now return sensible return values to reduce the risk of them being ignored. Also fixed a bug in `generic/gemv_t.c` resulting in weird outputs for `bgemv`.
Mousius
force-pushed
the
bgemm-correctness
branch
from
5b54afe to
578e7da
Compare
Mousius
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue originally introduced with the BGEMM kernel when I was tweaking it. #5287 didn't suffer from this bug.
I've updated the tests to run with
beta=1.0so as to test loading and updating from C.Alongside this, the tests now return sensible return values to reduce the risk of them being ignored.
Also fixed a bug in
generic/gemv_t.cresulting in weird outputs forbgemvwith updates.