Skip to content

Fix: Prevent Admin from demoting their own role (#9326) #9389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yasw175 wants to merge 1 commit into
base: dev
Choose a base branch
from
+14 −3
Open

Fix: Prevent Admin from demoting their own role (#9326) #9389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions packages/syft/src/syft/service/user/user_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,17 @@ def update(
# Get user to be updated by its UID
user = self.stash.get_by_uid(credentials=context.credentials, uid=uid).unwrap()

# FIX: Prevent Admin from demoting themselves (Issue #9326)
if (
updates_role
and user.verify_key == context.credentials
and user.role == ServiceRole.ADMIN
):
if user_update.role != ServiceRole.ADMIN:
raise SyftException(
public_message="Admins cannot demote their own role!"
)

immutable_fields = {"created_date", "updated_date", "deleted_date"}
updated_fields = user_update.to_dict(
exclude_none=True, exclude_empty=True
Expand Down Expand Up @@ -599,12 +610,12 @@ def exchange_credentials(self, context: UnauthedServiceContext) -> SyftSuccess:
and context.server.server_type == ServerType.ENCLAVE
and user.role == ServiceRole.ADMIN
):
# FIX: Replace with SyftException
# FIX: Replacing with SyftException
raise SyftException(
public_message=UserEnclaveAdminLoginError.public_message
)
else:
# FIX: Replace this below
# FIX: Replacing this below
raise SyftException(public_message=CredentialsError.public_message)

return SyftSuccess(message="Login successful.", value=user.to(UserPrivateKey))
Expand Down Expand Up @@ -729,4 +740,4 @@ def disable_notifications(


TYPE_TO_SERVICE[User] = UserService
SERVICE_TO_TYPES[UserService].update({User})
SERVICE_TO_TYPES[UserService].update({User})