Merged
Conversation
- Store ngrok_username in Settings alongside token for persistence
- ProxyService creates tunnel with subdomain: {username}.openmined.ngrok.app
- Auto-connect on startup restores tunnel with correct subdomain
- Reconnection maintains subdomain after connection loss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for storing and utilizing the ngrok username alongside the authentication token, enabling the use of a custom subdomain for ngrok tunnels. It also refactors the provisioner and healthcheck logic for improved clarity and reliability, and makes several improvements to settings and marketplace synchronization.
Ngrok username support and proxy service enhancements:
ngrok_usernamefield to theSettingsmodel and database, including migration and repository methods for storing and retrieving the username. (backend/syft_space/alembic/versions/616fe141adf9_save_ngrok_username_to_settings.py,backend/syft_space/components/settings/entities.py,backend/syft_space/components/settings/repository.py) [1] [2] [3]ProxyServiceto require and use the ngrok username when establishing tunnels, ensuring tunnels use a custom subdomain. This includes persisting the username, supporting auto-connect on startup, and handling reconnection logic with the username. (backend/syft_space/components/shared/proxy_service.py) [1] [2] [3] [4] [5] [6]backend/syft_space/components/settings/handlers.py) [1] [2]Settings and marketplace synchronization improvements:
sync_public_url_to_marketplaceto accept aMarketplaceinstance rather than aTenant. (backend/syft_space/components/settings/handlers.py)backend/syft_space/components/settings/handlers.py) [1] [2]Provisioner and healthcheck logic improvements:
backend/syft_space/components/dataset_types/weaviate_local/weaviate_provisioner.py) [1] [2] [3]backend/syft_space/components/datasets/handlers.py) [1] [2]Provisioner startup improvements:
backend/syft_space/components/datasets/provisioner_manager.py)