Skip to content

Conversation

tomast1337
Copy link
Member

@tomast1337 tomast1337 commented Sep 26, 2025

This update fixes our build and automation systems by:

  • creating a more structured and reliable build with the ./scripts/build.ts script.
  • Fixing some issues with the workflows on GitHub.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes package builds and GitHub workflows by introducing a structured build system and modernizing CI/CD configurations. The changes implement a sequential/parallel package build order and update workflow configurations for better dependency management.

  • Adds a new TypeScript build script that handles package dependencies and parallel builds
  • Updates package.json scripts to use workspace filtering and removes redundant commands
  • Modernizes GitHub workflow configurations with proper environment variables and cleaner step definitions

Reviewed Changes

Copilot reviewed 5 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
scripts/build.ts New build orchestration script defining package build order and parallel execution
packages/song/package.json Reorganizes dependencies and adds jszip dependency
package.json Simplifies scripts using workspace filtering and adds build automation
.github/workflows/tests.yml Adds environment variable and cleans up step descriptions
.github/workflows/lint.yml Fixes duplicate install steps and adds proper GitHub token configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@Bentroen Bentroen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request! The build command is much cleaner now, and it's much easier to visualize the dependency structure between the internal packages. ✨

As a general question, would it be possible to tidy up the run command to avoid the nominal reference to the frontend and backend packages, using something like --filter /apps/* (just like we do with Bun)?
If not, it's entirely fine to leave it as-is. Asking just to know if we could make it 'aware' of our new workspace's organization — one of the largest benefits of working with a monorepo —, so we can take full advantage of it.

Also, I've noticed some dependency and import changes in other parts of the project — are they related to the change at hand? If not, I'd suggest making them in a separate PR in the future, just to keep things focused :)

@tomast1337
Copy link
Member Author

@Bentroen

As a general question, would it be possible to tidy up the run command to avoid the nominal reference to the frontend and backend packages, using something like --filter /apps/* (just like we do with Bun)?
If not, it's entirely fine to leave it as-is. Asking just to know if we could make it 'aware' of our new workspace's organization — one of the largest benefits of working with a monorepo —, so we can take full advantage of it.

We can definitely use workspace filtering. I will explore it and improve this PR

Also, I've noticed some dependency and import changes in other parts of the project — are they related to the change at hand? If not, I'd suggest making them in a separate PR in the future, just to keep things focused :)

You're right to point that out. Those changes were fixes for issues I had introduced in a previous sloppy PR :S, the CI would not pass without it. Apologies for the noise.

@Bentroen
Copy link
Member

I understand we're juggling many responsibilities at the moment! The slips are entirely fine.

Once our refactoring initiative is complete, I believe it'll make it much easier to make PRs self-contained with only the relevant changes! :)

…t processes, adding support for apps and refining existing commands
@tomast1337
Copy link
Member Author

@Bentroen

I have updated the root package.json to use more of Bun's workspace features

@tomast1337 tomast1337 merged commit 14ebd6c into develop Sep 28, 2025
2 checks passed
@tomast1337 tomast1337 deleted the bugfix/git-flow-and-package-build branch September 28, 2025 00:45
@Bentroen Bentroen mentioned this pull request Oct 5, 2025
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants