Skip to content

Conversation

tomast1337
Copy link
Member

@tomast1337 tomast1337 commented Sep 28, 2025

This pull request revises the removal of the /api prefix from backend routes. It was found that some locations were still using the old /api/v1 path.

This change updates all remaining instances to use the correct /v1 prefix, ensuring consistency across the application.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request completes the removal of /api prefixes from backend routes by updating remaining instances that were still using the old /api/v1 path to use the new /v1 prefix.

  • Updates environment configuration files to use the new API URL format
  • Modifies authentication strategy callback URLs to remove /api prefix
  • Updates backend service fetch URLs and test cases
  • Corrects documentation examples to reflect the new route structure

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/frontend/.env.local.example Updates API URL environment variable to use /v1 instead of /api/v1
apps/backend/src/song/song-upload/song-upload.service.ts Updates fetch URLs for sound list data endpoints
apps/backend/src/auth/strategies/magicLinkEmail.strategy.ts Updates magic link callback and confirm URLs
apps/backend/src/auth/strategies/magicLinkEmail.strategy.spec.ts Updates test cases with new magic link callback URLs
apps/backend/src/auth/strategies/google.strategy.ts Updates Google OAuth callback URL
apps/backend/src/auth/strategies/github.strategy.ts Updates GitHub OAuth callback URL
apps/backend/src/auth/strategies/discord.strategy/index.ts Updates Discord OAuth callback URL
CONTRIBUTING.md Updates documentation examples with new API URL format

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@Bentroen Bentroen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing the missing places! I'll be merging the PR now.

@Bentroen Bentroen merged commit c9ffc37 into develop Sep 28, 2025
2 checks passed
@tomast1337 tomast1337 deleted the fix/api-prefix-removal branch September 28, 2025 01:12
@Bentroen Bentroen mentioned this pull request Sep 28, 2025
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants