Skip to content

Conversation

tomast1337
Copy link
Member

The project had multiple TypeScript typing issues preventing successful builds:

  • Jest type definitions missing in spec files
  • Package type exports not being generated properly
  • Frontend unable to import types from workspace packages
  • Missing type dependencies causing compilation errors

- Add Jest type definitions to backend package
- Fix database package TypeScript build configuration to generate .d.ts files
- Add @nbw/database dependency to frontend package
- Fix incorrect import paths in frontend components
- Add missing @types/unidecode dependency to song package
- Improve build script with proper build order and error handling
- Update frontend tsconfig to use bundler module resolution

All packages now build successfully with proper type exports.
@tomast1337 tomast1337 changed the base branch from main to develop September 28, 2025 22:41
- Remove unused Jest and Bun globals
- Add patterns to ignore test files (*.spec.ts, *.test.ts)
- Refactor import plugins for better TypeScript integration
Copy link
Member

@Bentroen Bentroen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Since not many files were changed, it could be better to merge #58 first, then re-lint the files changed here to avoid conflicts when merging.

tomast1337 and others added 12 commits September 29, 2025 21:40
…name adjustment

- Changed workspace name from note-block-world to @nbw/root
- Updated various package versions including @babel, @AWS-SDK, and @floating-ui
- Added new dependencies such as @borewit/text-codec and updated existing ones like @faker-js/faker and @fortawesome/fontawesome-svg-core
- Added @nbw/config as a workspace dependency in both package.json and bun.lock files.
- Added @nbw/config and @nbw/sounds to the build order in build.ts for improved package management.
…Generator

- Added checks to skip undefined notes in the SongStatsGenerator to prevent errors.
- Removed unnecessary TypeScript ignore comments for better code clarity.
- Updated build order in build.ts to ensure @nbw/sounds is built after @nbw/database.
…nNBS/NoteBlockWorld into feature/fix-typescript-typing-issues
@tomast1337 tomast1337 merged commit c7f60db into develop Oct 5, 2025
2 checks passed
@tomast1337 tomast1337 deleted the feature/fix-typescript-typing-issues branch October 5, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants