-
-
Notifications
You must be signed in to change notification settings - Fork 4
Fix TypeScript Typing Issues Across Monorepo #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Jest type definitions to backend package - Fix database package TypeScript build configuration to generate .d.ts files - Add @nbw/database dependency to frontend package - Fix incorrect import paths in frontend components - Add missing @types/unidecode dependency to song package - Improve build script with proper build order and error handling - Update frontend tsconfig to use bundler module resolution All packages now build successfully with proper type exports.
- Remove unused Jest and Bun globals - Add patterns to ignore test files (*.spec.ts, *.test.ts) - Refactor import plugins for better TypeScript integration
Bentroen
approved these changes
Sep 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Since not many files were changed, it could be better to merge #58 first, then re-lint the files changed here to avoid conflicts when merging.
…name adjustment - Changed workspace name from note-block-world to @nbw/root - Updated various package versions including @babel, @AWS-SDK, and @floating-ui - Added new dependencies such as @borewit/text-codec and updated existing ones like @faker-js/faker and @fortawesome/fontawesome-svg-core
- Added @nbw/config as a workspace dependency in both package.json and bun.lock files.
- Added @nbw/config and @nbw/sounds to the build order in build.ts for improved package management.
…Generator - Added checks to skip undefined notes in the SongStatsGenerator to prevent errors. - Removed unnecessary TypeScript ignore comments for better code clarity. - Updated build order in build.ts to ensure @nbw/sounds is built after @nbw/database.
…nNBS/NoteBlockWorld into feature/fix-typescript-typing-issues
…ure/fix-typescript-typing-issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project had multiple TypeScript typing issues preventing successful builds: