NMS-19440: SNMP Config revised Lookup UI #8247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synqotik
force-pushed
the
jira/NMS-19440-snmp-config-revised-lookup-ui
branch
from
ae7b41e to
96d8d2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revising the SNMP Config Lookup and also Edit Definition screens to be much closer to the UX Figma prototype.
Wired up saving a configuration to the Rest API, for individual IP or IP range.
Validation of SNMP configuration fields before saving.
You can also edit a Definition, it will pre-fill the first/last IP address in the first range. You can edit the Definition, it will bring you to basically the same screen as the edit screen after a Lookup, and you can change configuration for an IP address or range. We just don't yet support changing config for multiple non-contiguous ranges.
Did quite a bit of refactoring. Added unit tests for
snmpValidator. Added some license headers to files that were missing them. There are a couple of smallerTODOitems that can be handled subsequently.See Jira issue for screenshots.
External References