NMS-19542: Add search to SNMP Config definitions and profiles, layout updates#8350
Merged
synqotik merged 9 commits intofeatures/snmp-config-db-migrationfrom Mar 16, 2026
Merged
Conversation
synqotik
force-pushed
the
jira/NMS-19542-snmp-config-search
branch
from
448cc27 to
512633e
Compare
synqotik
changed the title
synqotik
force-pushed
the
jira/NMS-19542-snmp-config-search
branch
from
512633e to
6053098
Compare
synqotik
force-pushed
the
jira/NMS-19542-snmp-config-search
branch
from
bab63a0 to
3d80598
Compare
cgorantla
approved these changes
Mar 16, 2026
ui/CLAUDE.md
Outdated
| @@ -0,0 +1,266 @@ | |||
| # OpenNMS UI — Claude Instructions | |||
Contributor
There was a problem hiding this comment.
Let's not check-in this file. This eats up context every time someone loads claude. You can keep it local for now.
synqotik
merged commit c7a7dce
into
features/snmp-config-db-migration
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add search to SNMP Config definitions and profiles.
This is a case-insensitive, client-side search. There should not be more than say 50-100 definitions, so server-side search is not really necessary.
For definitions, this searches
location(i.e. Monitoring Location) as well as any part of any specific IP, IP range or IPLIKE expression.For profiles, this searches
labelsandfilter expressions.In addition, this PR makes various changes to the overall layout.
Changed the tabs to have this structure:
|-- Lookup by IP panel
|-- Definitions
|-- Profiles
|-- Default Configuration
Moved the Upload and Download buttons to the top of the container and removed the separate page.
Created a common
ActionDropdownButtoncomponent to encapsulate an icon button with a dropdown where user can choose e.g. XML or Json format for upload/download. We could enhance and use this common component elsewhere as well.Added some more explanatory text, clicking on an info icon opens a dialog displaying more detailed instructions. Updated some of the wording to make it more understandable.
This is an initial search functionality, we may add more searching/filtering in the future.
Also I realized there wasn't pagination on the profiles page, so that has been added.
And, added an initial
ui/CLAUDE.md.NOTE: we are encountering unit test issues unrelated to this ticket failing the UI build to fail on CI. I fixed some using some extra handling for timers, but ending up having to skip a lot of tests for now. I will open a separate ticket to investigate those. Most of the issues have to do with cases where there are timers involved, for example when we
debouncein the UI for autocomplete or other text input. Many pass locally but fail in CI. Honestly, many of those unit tests are not really that critical, they aren't testing core business logic, so OK to skip until we can fix them.External References