NMS-19602: exception on interface rescan page#8353
Merged
dino2gnt merged 1 commit intofoundation-2024from Mar 16, 2026
Merged
Conversation
dino2gnt
requested review from
cgorantla,
christianpape,
marshallmassengill and
synqotik
cgorantla
previously approved these changes
Mar 13, 2026
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
Looks fine to me if we already sanitizing interfaceLink.
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm always reluctant to remove escapes and sanitization, but the
escapeXml()function wrapping this should be redundant as we already sanitize the interface parameter before we build theinterfaceLink.Pushing the
fn:escapeXml(interfaceLink)out to ac:set var=something ...and then referencing${something}in the breadcrumb didn't seem to change the resulting link when I polluted the parameter with tags, so I dropped it entirely. 🤷External References