NMS-19610: When Minions are upgraded to 35.0.4 the location and Minion ID is overwritten#8358
NMS-19610: When Minions are upgraded to 35.0.4 the location and Minion ID is overwritten#8358mershad-manesh wants to merge 7 commits intorelease-35.xfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent Minion upgrades (to 35.0.4) from overwriting the Minion ID and location by marking the controller configuration as a Debian conffile so dpkg preserves local changes across upgrades.
Changes:
- Add a Debian
conffilesentry for the Minion controller configuration file.
Comments suppressed due to low confidence (1)
opennms-assemblies/minion/src/main/filtered/debian/opennms-minion.conffiles:2
- This conffiles file currently contains an extra blank line after the path. Debian conffiles lists should contain only valid absolute paths (one per line); remove the empty line to avoid dpkg/debhelper parsing issues.
/opt/minion/etc/org.opennms.minion.controller.cfg
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1 @@ | |||
| /opt/minion/etc/org.opennms.minion.controller.cfg | |||
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent Debian package upgrades from overwriting Minion identity/location settings by marking the Minion controller configuration as a dpkg-managed conffile.
Changes:
- Add a Debian
opennms-minion.conffilesentry for the Minion controller config.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
opennms-assemblies/minion/src/main/filtered/debian/opennms-minion.conffiles
Outdated
Show resolved
Hide resolved
|
Copilot is half-right. This should target |
Copilot is half-right. This should target release-35.x and/or develop - foundation-2025 doesn't appear to have the path updates for minion yet.
All Contributors
External References