Skip to content

NMS-19610: When Minions are upgraded to 35.0.4 the location and Minion ID is overwritten#8358

Closed
mershad-manesh wants to merge 7 commits intorelease-35.xfrom
mem/NMS-19610-smoke
Closed

NMS-19610: When Minions are upgraded to 35.0.4 the location and Minion ID is overwritten#8358
mershad-manesh wants to merge 7 commits intorelease-35.xfrom
mem/NMS-19610-smoke

Conversation

@mershad-manesh
Copy link
Contributor

All Contributors

External References

dino2gnt
dino2gnt previously approved these changes Mar 16, 2026
Copy link
Contributor

@dino2gnt dino2gnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peachy.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent Minion upgrades (to 35.0.4) from overwriting the Minion ID and location by marking the controller configuration as a Debian conffile so dpkg preserves local changes across upgrades.

Changes:

  • Add a Debian conffiles entry for the Minion controller configuration file.
Comments suppressed due to low confidence (1)

opennms-assemblies/minion/src/main/filtered/debian/opennms-minion.conffiles:2

  • This conffiles file currently contains an extra blank line after the path. Debian conffiles lists should contain only valid absolute paths (one per line); remove the empty line to avoid dpkg/debhelper parsing issues.
/opt/minion/etc/org.opennms.minion.controller.cfg


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1 @@
/opt/minion/etc/org.opennms.minion.controller.cfg
dino2gnt
dino2gnt previously approved these changes Mar 16, 2026
Copy link
Contributor

@dino2gnt dino2gnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peachy-er.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent Debian package upgrades from overwriting Minion identity/location settings by marking the Minion controller configuration as a dpkg-managed conffile.

Changes:

  • Add a Debian opennms-minion.conffiles entry for the Minion controller config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dino2gnt dino2gnt self-requested a review March 16, 2026 15:46
@dino2gnt
Copy link
Contributor

Copilot is half-right. This should target release-35.x and/or develop - foundation-2025 doesn't appear to have the path updates for minion yet.

@dino2gnt dino2gnt dismissed their stale review March 16, 2026 15:48

Copilot is half-right. This should target release-35.x and/or develop - foundation-2025 doesn't appear to have the path updates for minion yet.

@mershad-manesh mershad-manesh changed the base branch from foundation-2025 to release-35.x March 16, 2026 16:47
@mershad-manesh mershad-manesh deleted the mem/NMS-19610-smoke branch March 16, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants