OpenPRoT · lxuxx · Aug 7, 2025 · Jun 13, 2025 · Jun 21, 2025 · Jun 23, 2025
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -17,6 +17,7 @@ edition = "2021"
 [features]
 default = []
 std = []
+i2c_target = []
 test-rsa = []
 test-ecdsa = []
 test-hmac = []
@@ -33,6 +34,7 @@ embedded-io = "0.6.1"
 fugit = "0.3.7"
 proposed-traits = { git = "https://github.com/rusty1968/proposed_traits.git", package = "proposed-traits", rev = "85641310df5a5276c67f81621b104322cff0286c" }
 hex-literal = "0.4"
+heapless = "0.8.0"
 nb = "1.1.0"
 paste = "1.0"
 

diff --git a/src/common.rs b/src/common.rs
@@ -1,5 +1,9 @@
 // Licensed under the Apache-2.0 license
 
+use crate::uart::UartController;
+use core::ops::{Index, IndexMut};
+use embedded_io::Write;
+
-
+trait I2cHardware {
+    type Config: Clone + core::fmt::Debug;
+    type Error;
+    
+    fn reset(&mut self);
+    fn configure(&mut self, config: &Self::Config) -> Result<(), Self::Error>;
+    fn enable_interrupts(&mut self, mask: u32);
+    fn clear_interrupts(&mut self, mask: u32);
+    fn start_transfer(&mut self, state: &TransferState) -> Result<(), Self::Error>;
+    fn handle_interrupt(&mut self) -> InterruptStatus<Self::Error>;
+    fn is_bus_busy(&self) -> bool;
+    fn recover_bus(&mut self) -> Result<(), Self::Error>;
+}
-
+trait I2cHardware {
+    type Config: Clone + core::fmt::Debug;
+    type Error;
+    
+    fn reset(&mut self);
+    fn configure(&mut self, config: &Self::Config) -> Result<(), Self::Error>;
+    fn enable_interrupts(&mut self, mask: u32);
+    fn clear_interrupts(&mut self, mask: u32);
+    fn start_transfer(&mut self, state: &TransferState) -> Result<(), Self::Error>;
+    fn handle_interrupt(&mut self) -> InterruptStatus<Self::Error>;
+    fn is_bus_busy(&self) -> bool;
+    fn recover_bus(&mut self) -> Result<(), Self::Error>;
+}
 pub struct DummyDelay;
 
 impl embedded_hal::delay::DelayNs for DummyDelay {
@@ -38,27 +42,25 @@ impl<const N: usize> DmaBuffer<N> {
     }
 
     #[must_use]
-    pub fn len(&self) -> usize {
+    pub const fn len(&self) -> usize {
         N
     }
 
     #[must_use]
-    pub fn is_empty(&self) -> bool {
+    pub const fn is_empty(&self) -> bool {
         N == 0
     }
 
     #[must_use]
-    pub fn as_slice(&self) -> &[u8] {
-        &self.buf
+    pub fn as_slice(&self, start: usize, end: usize) -> &[u8] {
+        &self.buf[start..end]
     }
 
     pub fn as_mut_slice(&mut self, start: usize, end: usize) -> &mut [u8] {
         &mut self.buf[start..end]
     }
 }
 
-use core::ops::{Index, IndexMut};
-
 impl<const N: usize> Index<usize> for DmaBuffer<N> {
     type Output = u8;
     fn index(&self, idx: usize) -> &Self::Output {
@@ -71,3 +73,37 @@ impl<const N: usize> IndexMut<usize> for DmaBuffer<N> {
         &mut self.buf[idx]
     }
 }
+
+pub trait Logger {
+    fn debug(&mut self, msg: &str);
+    fn error(&mut self, msg: &str);
+}
+
+// No-op implementation for production builds
+pub struct NoOpLogger;
+impl Logger for NoOpLogger {
+    fn debug(&mut self, _msg: &str) {}
+    fn error(&mut self, _msg: &str) {}
+}
+
+// UART logger adapter (separate concern)
+pub struct UartLogger<'a> {
+    uart: &'a mut UartController<'a>,
+}
+
+impl<'a> UartLogger<'a> {
+    pub fn new(uart: &'a mut UartController<'a>) -> Self {
+        UartLogger { uart }
+    }
+}
+
+impl<'a> Logger for UartLogger<'a> {
+    fn debug(&mut self, msg: &str) {
+        writeln!(self.uart, "{msg}").ok();
+        write!(self.uart, "\r").ok();
+    }
+    fn error(&mut self, msg: &str) {
+        writeln!(self.uart, "ERROR: {msg}").ok();
+        write!(self.uart, "\r").ok();
+    }
+}