feat(hal): Add comprehensive ECDSA traits with curve markers #22
+1,230
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rusty1968
commented
Sep 4, 2025
rusty1968
commented
- Add complete ECDSA trait suite (key generation, signing, verification)
- Include security-first design with mandatory validation and zeroization
- Add curve markers for P256, P384, P521, secp256k1, and Brainpool curves
- Implement type-safe generic interface preventing cross-curve contamination
- Add comprehensive error handling with detailed ErrorKind enum
- Include extensive documentation with security considerations and examples.
- Add complete ECDSA trait suite (key generation, signing, verification) - Include security-first design with mandatory validation and zeroization - Add curve markers for P256, P384, P521, secp256k1, and Brainpool curves - Implement type-safe generic interface preventing cross-curve contamination - Add comprehensive error handling with detailed ErrorKind enum - Include extensive documentation with security considerations and examples.
rusty1968
force-pushed
the
ecdsa-trait
branch
from
cf3e338 to
093796b
Compare
rusty1968
force-pushed
the
ecdsa-trait
branch
from
093796b to
1e3823a
Compare
FerralCoder
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.