Conversation
FerralCoder
approved these changes
Oct 30, 2025
FerralCoder
previously approved these changes
Oct 30, 2025
FerralCoder
previously approved these changes
Oct 30, 2025
rusty1968
force-pushed
the
hmac-owned
branch
2 times, most recently
from
b44e760 to
a1d7e1a
Compare
FerralCoder
previously approved these changes
Oct 31, 2025
…oped and owned patterns
…nt context (ipc server).
… implementation - Add RustCryptoController as unified trait implementation for digest and MAC - Consolidate SHA-256/384/512 digest and HMAC-SHA operations in one type - Remove redundant digest.rs and hash.rs modules - Update MAC traits to use generic key handle design for better security - Update dependencies to support unified trait implementation The RustCryptoController serves as a stateless Hubris-compatible type that implements both digest and MAC traits with proper generic key handling.
…oper error handling
- Add `HubrisDigestDevice` trait with concrete associated types - Implement `HubrisCryptoError` for IDL-compatible error handling - Support SHA-256/384/512 digest operations with move semantics - Add HMAC-SHA256/384/512 support with secure key management - Include one-shot operation convenience methods ### RustCrypto Controller Integration - Implement `HubrisDigestDevice` for `RustCryptoController` - Add `SecureOwnedKey` with stack-allocated 128-byte buffer - Fix unsafe indexing operations with bounds-checked alternatives - Suppress deprecation warnings for ecosystem compatibility
FerralCoder
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owned API is a modern pattern in OpenPRoT HAL that uses Rust's move semantics for safe, zero-cost cryptographic operations. Unlike the reference-based APIs, owned APIs transfer ownership of contexts between operations.
This mirrors the digest owned API pattern but adds key management for MAC operations.