-
-
Notifications
You must be signed in to change notification settings - Fork 3
deps: bump postgres from 17.2 to 17.4 #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump postgres from 17.2 to 17.4 #236
Conversation
Signed-off-by: Sebastian Beltran <[email protected]>
## Walkthrough
The Docker Compose configuration and GitHub Actions workflows were updated to use PostgreSQL image version 17.4 instead of 17.2. Additionally, the database schema dump was modified to add cascading update and delete behavior to two foreign key constraints in the `resources_for_compliance_checks` table.
## Changes
| File(s) | Change Summary |
|-----------------------------------------------|-----------------------------------------------------------------------------------------------------------|
| docker-compose.yml | Updated PostgreSQL image version from 17.2 to 17.4 for `db` and `schema-dump` services. |
| .github/workflows/ci.yml, .github/workflows/e2e-tests.yml | Updated PostgreSQL image version from 17.2 to 17.4 in CI and end-to-end test workflows. |
| src/database/schema/schema.sql | Modified two foreign key constraints on `resources_for_compliance_checks` to add `ON UPDATE CASCADE ON DELETE CASCADE`. |
## Poem
> 🐇
> A hop and a skip, to version seventeen-four,
> Our Compose file’s fresher than ever before!
> The database hums with a patch so new,
> Cascading keys now keep data true.
> With every small upgrade, our stack’s in its prime—
> Hooray for the future, one hop at a time!
>Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
UlisesGascon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to update also the pipelines:
| image: postgres:17.2 |
visionBoard/.github/workflows/ci.yml
Line 17 in 424ae8c
| image: postgres:17.2 |
And probably run npm run db:generate-schema to refresh the version references (context)
Signed-off-by: Sebastian Beltran <[email protected]>
|
|
||
| ALTER TABLE ONLY public.resources_for_compliance_checks | ||
| ADD CONSTRAINT resources_for_compliance_checks_compliance_check_id_foreign FOREIGN KEY (compliance_check_id) REFERENCES public.compliance_checks(id); | ||
| ADD CONSTRAINT resources_for_compliance_checks_compliance_check_id_foreign FOREIGN KEY (compliance_check_id) REFERENCES public.compliance_checks(id) ON UPDATE CASCADE ON DELETE CASCADE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't altered the tables manually, and the database is a new instance since I recently formatted my computer. I assume it's due to the new version. I've also done a rollback and re-applied the migrations to be sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this update actually was missing from previous PRs, so makes sense to include it 👍
UlisesGascon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
|
||
| ALTER TABLE ONLY public.resources_for_compliance_checks | ||
| ADD CONSTRAINT resources_for_compliance_checks_compliance_check_id_foreign FOREIGN KEY (compliance_check_id) REFERENCES public.compliance_checks(id); | ||
| ADD CONSTRAINT resources_for_compliance_checks_compliance_check_id_foreign FOREIGN KEY (compliance_check_id) REFERENCES public.compliance_checks(id) ON UPDATE CASCADE ON DELETE CASCADE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this update actually was missing from previous PRs, so makes sense to include it 👍
Postgres is being updated to the latest version. I believe this isn't in production yet, so there's nothing to do for now, besides that.
Summary by CodeRabbit