-
Notifications
You must be signed in to change notification settings - Fork 94
Fix DeprecationWarning: Removed Gdk.threads_enter/leave calls #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @dk8877 , thank you for the PR! I see you commented out the threads methods - can you remove them if they are not needed? |
|
ohk i will do it soon |
5ecccf5 to
3bbeaaa
Compare
|
Done! I have removed the ines @zdohnal |
zdohnal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some issues with indentation and some lines are not needed anymore, would you mind looking into it?
3bbeaaa to
6ecd735
Compare
|
@zdohnal Thanks for the review! I have addressed all the points: |
zdohnal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some unnecessary changes in indentation and one try: block was removed incorrectly (we catch exception there, try: will stay) - please look into it.
Thank you in advance!
6ecd735 to
c70217c
Compare
|
@zdohnal Thanks for the review! I have fixed the issues. You can review it now. |
Removes the deprecated Gdk.threads_enter() and Gdk.threads_leave() calls.
Modern Gdk handles thread locking automatically, so these manual locks are no longer needed and cause DeprecationWarnings.
Tested locally on Fedora; the application launches correctly and the specific DeprecationWarning is gone.
Closes #126