Updated ModSDK files to playtest-20241116 #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Oops I didn't check for code violations after updating the |
Member
Author
|
Updated. |
pchote
reviewed
Dec 15, 2024
| void ITick.Tick(Actor self) | ||
| { | ||
| t += 1; | ||
| t++; |
Member
There was a problem hiding this comment.
This could simplify further to if (++t > 2)
Member
|
Can you please also change: Line 296 in 56e4800 to: $env:MOD_SEARCH_PATHS = "./mods" This should hopefully fix the Windows CI failure. |
Member
Author
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get in line with OpenRA/OpenRAModSDK#198.
The
.editorconfigis a copy of the one used in the main OpenRA repo.The rest is trivial.