consolefont: change parameter order for compatibility with kbd >=2.7 #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newly released kbd 2.7 includes a rewrite of the setfont argument parser, with this rewritten parser command-line option need to be passed **before** the font. Otherwise, the parameters will be interpreted as font names. Without this patch, this causes the consolefont service to fail with the following error message: setfont: Unable to find file: -C Note that the setfont(1) man page still recommends passing -C after the font name. I am not sure if this is a documentation or implementation issue. See: legionus/kbd@aed486b
Contributor
Author
Created a kbd issue: legionus/kbd#122 |
Contributor
Author
|
This turned out to be a bug in kbd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly released kbd 2.7 includes a rewrite of the setfont argument parser, with this rewritten parser command-line option need to be passed before the font. Otherwise, the parameters will be interpreted as font names. Without this patch, this causes the consolefont service to fail with the following error message:
Note that the
setfont(8)man page still recommends passing -C after the font name. I am not sure if this is a documentation or implementation issue.See: legionus/kbd@aed486b