wait for exclusive fds properly #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navi-desu
force-pushed
the
parallel_rework
branch
from
0e45a20 to
1e6b8e7
Compare
N-R-K
suggested changes
Apr 6, 2025
N-R-K
reviewed
Apr 6, 2025
navi-desu
force-pushed
the
parallel_rework
branch
from
1e6b8e7 to
1cafa17
Compare
navi-desu
commented
Apr 6, 2025
N-R-K
suggested changes
Apr 6, 2025
navi-desu
force-pushed
the
parallel_rework
branch
2 times, most recently
from
3eed883 to
fb3c6f9
Compare
navi-desu
commented
Apr 6, 2025
navi-desu
force-pushed
the
parallel_rework
branch
3 times, most recently
from
844d529 to
75faaf3
Compare
N-R-K
reviewed
Apr 6, 2025
Contributor
N-R-K
left a comment
N-R-K
left a comment
There was a problem hiding this comment.
The poll part of the changes look much better now.
Will review and test the rest of the changes sometime this week.
navi-desu
force-pushed
the
parallel_rework
branch
2 times, most recently
from
1259a42 to
57b472c
Compare
N-R-K
suggested changes
Apr 6, 2025
navi-desu
force-pushed
the
parallel_rework
branch
2 times, most recently
from
3490c8b to
65d07dc
Compare
Member
Author
|
okay so, the changes to the dependency code can have some racy edge cases as it was, so i'll drop them for now and work on them again at a later date so for now, let's just get the refactors for proper waiting in |
navi-desu
changed the title
N-R-K
reviewed
Apr 9, 2025
it makes no sense for the parent to hold the lock, even with cloexec, and that makes attempts to wait on flock useless. it only worked so far due to busy-polling with open, so basically, we were waiting for an unlink, not a lockfile.
and use alarm.2 for timing out, this means that instead of waking up every 20ms and doing a few syscalls to check the lockfile, we wake up only every 10s for warning about the timeout
navi-desu
force-pushed
the
parallel_rework
branch
from
65d07dc to
7069e8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exec_serviceopenrcwith the codepath ofrc-service, and i think that allows for better parallelism (not sure, need to test some more)