openrc-run misc fixes #872
Merged
+245
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navi-desu
force-pushed
the
openrc-run-fixes
branch
from
d904660 to
a6066fa
Compare
N-R-K
reviewed
May 27, 2025
Comment on lines
-68
to
+69
| if [ -z "$1" -o -z "$2" ]; then | ||
| eerror "$RC_SVCNAME: not enough arguments" | ||
| if [ $# != 2 ]; then | ||
| eerror "$RC_SVCNAME: invalid arguments" |
Contributor
There was a problem hiding this comment.
Not the same since "" "" will count as 2 arguments and will pass this test. But -z would've detect them to be empty.
Member
Author
There was a problem hiding this comment.
for $2, it'd be handled bellow as an invalid function, passing "" shouldn't be handled differently than "foonyamew" when such command doesn't exist, imo
for $1, openrc-run.c already bails out if it's not a file path to a file with the exec bit set
Member
Author
There was a problem hiding this comment.
tbh this whole check is kindof meh, considering the preconditions for our internal script to be executed, i think
navi-desu
force-pushed
the
openrc-run-fixes
branch
from
a6066fa to
e1da916
Compare
openrc-ruh.sh is only ever called from openrc-run.c, with a single command, so looping over "$@" is unnecessary
svc_exec is always called with `command, NULL`, the second argument is never actually used.
navi-desu
force-pushed
the
openrc-run-fixes
branch
from
e1da916 to
b946470
Compare
navi-desu
force-pushed
the
openrc-run-fixes
branch
from
c6fd038 to
8dee937
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.